From b0bb99f413113576ab31bf923727798208b48051 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 30 Jun 2022 16:00:05 +0200 Subject: [PATCH] test: unflake React.js and Vue tests (#15264) React takes time to render on overbooked machines. Let's use web-first assertions to test that they work as expected. Error: expect(received).toBe(expected) // Object.is equality Expected: 1 Received: 0 at /home/runner/work/playwright/playwright/tests/page/selectors-react.spec.ts:34:71 image --- tests/page/selectors-react.spec.ts | 99 +++++++++++++++--------------- tests/page/selectors-vue.spec.ts | 95 ++++++++++++++-------------- 2 files changed, 97 insertions(+), 97 deletions(-) diff --git a/tests/page/selectors-react.spec.ts b/tests/page/selectors-react.spec.ts index 913bed07f9..8aecf26a20 100644 --- a/tests/page/selectors-react.spec.ts +++ b/tests/page/selectors-react.spec.ts @@ -31,89 +31,88 @@ for (const [name, url] of Object.entries(reacts)) { }); it('should work with single-root elements @smoke', async ({ page }) => { - expect(await page.$$eval(`_react=BookList`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=BookItem`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=BookList >> _react=BookItem`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=BookItem >> _react=BookList`, els => els.length)).toBe(0); - + await expect(page.locator(`_react=BookList`)).toHaveCount(1); + await expect(page.locator(`_react=BookItem`)).toHaveCount(3); + await expect(page.locator(`_react=BookList >> _react=BookItem`)).toHaveCount(3); + await expect(page.locator(`_react=BookItem >> _react=BookList`)).toHaveCount(0); }); it('should work with multi-root elements (fragments)', async ({ page }) => { it.skip(name === 'react15', 'React 15 does not support fragments'); - expect(await page.$$eval(`_react=App`, els => els.length)).toBe(15); - expect(await page.$$eval(`_react=AppHeader`, els => els.length)).toBe(2); - expect(await page.$$eval(`_react=NewBook`, els => els.length)).toBe(2); + await expect(page.locator(`_react=App`)).toHaveCount(15); + await expect(page.locator(`_react=AppHeader`)).toHaveCount(2); + await expect(page.locator(`_react=NewBook`)).toHaveCount(2); }); it('should not crash when there is no match', async ({ page }) => { - expect(await page.$$eval(`_react=Apps`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=BookLi`, els => els.length)).toBe(0); + await expect(page.locator(`_react=Apps`)).toHaveCount(0); + await expect(page.locator(`_react=BookLi`)).toHaveCount(0); }); it('should compose', async ({ page }) => { - expect(await page.$eval(`_react=NewBook >> _react=button`, el => el.textContent)).toBe('new book'); + await expect(page.locator(`_react=NewBook >> _react=button`)).toHaveText('new book'); expect(await page.$eval(`_react=NewBook >> _react=input`, el => el.tagName)).toBe('INPUT'); - expect(await page.$eval(`_react=BookItem >> text=Gatsby`, el => el.textContent)).toBe('The Great Gatsby'); + await expect(page.locator(`_react=BookItem >> text=Gatsby`)).toHaveText('The Great Gatsby'); }); it('should query by props combinations', async ({ page }) => { - expect(await page.$$eval(`_react=BookItem[name="The Great Gatsby"]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=BookItem[name="the great gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=li[key="The Great Gatsby"]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=ColorButton[nested.index = 0]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=ColorButton[nested.nonexisting.index = 0]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=ColorButton[nested.index.nonexisting = 0]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=ColorButton[nested.index.nonexisting = 1]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=ColorButton[nested.value = 4.1]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=ColorButton[enabled = false]`, els => els.length)).toBe(4); - expect(await page.$$eval(`_react=ColorButton[enabled = true] `, els => els.length)).toBe(5); - expect(await page.$$eval(`_react=ColorButton[enabled = true][color = "red"]`, els => els.length)).toBe(2); - expect(await page.$$eval(`_react=ColorButton[enabled = true][color = "red"i][nested.index = 6]`, els => els.length)).toBe(1); + await expect(page.locator(`_react=BookItem[name="The Great Gatsby"]`)).toHaveCount(1); + await expect(page.locator(`_react=BookItem[name="the great gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_react=li[key="The Great Gatsby"]`)).toHaveCount(1); + await expect(page.locator(`_react=ColorButton[nested.index = 0]`)).toHaveCount(1); + await expect(page.locator(`_react=ColorButton[nested.nonexisting.index = 0]`)).toHaveCount(0); + await expect(page.locator(`_react=ColorButton[nested.index.nonexisting = 0]`)).toHaveCount(0); + await expect(page.locator(`_react=ColorButton[nested.index.nonexisting = 1]`)).toHaveCount(0); + await expect(page.locator(`_react=ColorButton[nested.value = 4.1]`)).toHaveCount(1); + await expect(page.locator(`_react=ColorButton[enabled = false]`)).toHaveCount(4); + await expect(page.locator(`_react=ColorButton[enabled = true] `)).toHaveCount(5); + await expect(page.locator(`_react=ColorButton[enabled = true][color = "red"]`)).toHaveCount(2); + await expect(page.locator(`_react=ColorButton[enabled = true][color = "red"i][nested.index = 6]`)).toHaveCount(1); }); it('should exact match by props', async ({ page }) => { - expect(await page.$eval(`_react=BookItem[name = "The Great Gatsby"]`, el => el.textContent)).toBe('The Great Gatsby'); - expect(await page.$$eval(`_react=BookItem[name = "The Great Gatsby"]`, els => els.length)).toBe(1); + await expect(page.locator(`_react=BookItem[name = "The Great Gatsby"]`)).toHaveText('The Great Gatsby'); + await expect(page.locator(`_react=BookItem[name = "The Great Gatsby"]`)).toHaveCount(1); // case sensetive by default - expect(await page.$$eval(`_react=BookItem[name = "the great gatsby"]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=BookItem[name = "the great gatsby" s]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=BookItem[name = "the great gatsby" S]`, els => els.length)).toBe(0); + await expect(page.locator(`_react=BookItem[name = "the great gatsby"]`)).toHaveCount(0); + await expect(page.locator(`_react=BookItem[name = "the great gatsby" s]`)).toHaveCount(0); + await expect(page.locator(`_react=BookItem[name = "the great gatsby" S]`)).toHaveCount(0); // case insensetive with flag - expect(await page.$$eval(`_react=BookItem[name = "the great gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=BookItem[name = "the great gatsby" I]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=BookItem[name = " The Great Gatsby "]`, els => els.length)).toBe(0); + await expect(page.locator(`_react=BookItem[name = "the great gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_react=BookItem[name = "the great gatsby" I]`)).toHaveCount(1); + await expect(page.locator(`_react=BookItem[name = " The Great Gatsby "]`)).toHaveCount(0); }); it('should partially match by props', async ({ page }) => { // Check partial matching - expect(await page.$eval(`_react=BookItem[name *= "Gatsby"]`, el => el.textContent)).toBe('The Great Gatsby'); - expect(await page.$$eval(`_react=BookItem[name *= "Gatsby"]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=[name *= "Gatsby"]`, els => els.length)).toBe(1); + await expect(page.locator(`_react=BookItem[name *= "Gatsby"]`)).toHaveText('The Great Gatsby'); + await expect(page.locator(`_react=BookItem[name *= "Gatsby"]`)).toHaveCount(1); + await expect(page.locator(`_react=[name *= "Gatsby"]`)).toHaveCount(1); - expect(await page.$$eval(`_react=BookItem[name = "Gatsby"]`, els => els.length)).toBe(0); + await expect(page.locator(`_react=BookItem[name = "Gatsby"]`)).toHaveCount(0); }); it('should support all string operators', async ({ page }) => { - expect(await page.$$eval(`_react=ColorButton[color = "red"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color |= "red"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color $= "ed"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color ^= "gr"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color ~= "e"]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=BookItem[name ~= "gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_react=BookItem[name *= " gatsby" i]`, els => els.length)).toBe(1); + await expect(page.locator(`_react=ColorButton[color = "red"]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color |= "red"]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color $= "ed"]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color ^= "gr"]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color ~= "e"]`)).toHaveCount(0); + await expect(page.locator(`_react=BookItem[name ~= "gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_react=BookItem[name *= " gatsby" i]`)).toHaveCount(1); }); it('should support regex', async ({ page }) => { - expect(await page.$$eval(`_react=ColorButton[color = /red/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color = /^red$/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color = /RED/i]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color = /[pqr]ed/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_react=ColorButton[color = /[pq]ed/]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_react=BookItem[name = /gat.by/i]`, els => els.length)).toBe(1); + await expect(page.locator(`_react=ColorButton[color = /red/]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color = /^red$/]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color = /RED/i]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color = /[pqr]ed/]`)).toHaveCount(3); + await expect(page.locator(`_react=ColorButton[color = /[pq]ed/]`)).toHaveCount(0); + await expect(page.locator(`_react=BookItem[name = /gat.by/i]`)).toHaveCount(1); }); it('should support truthy querying', async ({ page }) => { - expect(await page.$$eval(`_react=ColorButton[enabled]`, els => els.length)).toBe(5); + await expect(page.locator(`_react=ColorButton[enabled]`)).toHaveCount(5); }); it('should support nested react trees', async ({ page }) => { diff --git a/tests/page/selectors-vue.spec.ts b/tests/page/selectors-vue.spec.ts index 1412a100d9..1fce5b320d 100644 --- a/tests/page/selectors-vue.spec.ts +++ b/tests/page/selectors-vue.spec.ts @@ -29,90 +29,91 @@ for (const [name, url] of Object.entries(vues)) { }); it('should work with single-root elements @smoke', async ({ page }) => { - expect(await page.$$eval(`_vue=book-list`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=book-list`)).toHaveCount(1); + // count() was not working, see: https://github.com/microsoft/playwright/issues/12887 expect(await page.locator(`_vue=book-list`).count()).toBe(1); await expect(page.locator(`_vue=book-list`)).toHaveCount(1); - expect(await page.$$eval(`_vue=book-item`, els => els.length)).toBe(3); + await expect(page.locator(`_vue=book-item`)).toHaveCount(3); expect(await page.locator(`_vue=book-item`).count()).toBe(3); await expect(page.locator(`_vue=book-item`)).toHaveCount(3); - expect(await page.$$eval(`_vue=book-list >> _vue=book-item`, els => els.length)).toBe(3); + await expect(page.locator(`_vue=book-list >> _vue=book-item`)).toHaveCount(3); expect(await page.locator(`_vue=book-list >> _vue=book-item`).count()).toBe(3); - expect(await page.$$eval(`_vue=book-item >> _vue=book-list`, els => els.length)).toBe(0); + await expect(page.locator(`_vue=book-item >> _vue=book-list`)).toHaveCount(0); }); it('should work with multi-root elements (fragments)', async ({ page }) => { it.skip(name === 'vue2', 'vue2 does not support fragments'); - expect(await page.$$eval(`_vue=Root`, els => els.length)).toBe(15); - expect(await page.$$eval(`_vue=app-header`, els => els.length)).toBe(2); - expect(await page.$$eval(`_vue=new-book`, els => els.length)).toBe(2); + await expect(page.locator(`_vue=Root`)).toHaveCount(15); + await expect(page.locator(`_vue=app-header`)).toHaveCount(2); + await expect(page.locator(`_vue=new-book`)).toHaveCount(2); }); it('should not crash when there is no match', async ({ page }) => { - expect(await page.$$eval(`_vue=apps`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=book-li`, els => els.length)).toBe(0); + await expect(page.locator(`_vue=apps`)).toHaveCount(0); + await expect(page.locator(`_vue=book-li`)).toHaveCount(0); }); it('should compose', async ({ page }) => { - expect(await page.$eval(`_vue=book-item >> text=Gatsby`, el => el.textContent.trim())).toBe('The Great Gatsby'); + await expect(page.locator(`_vue=book-item >> text=Gatsby`)).toHaveText('The Great Gatsby'); }); it('should query by props combinations', async ({ page }) => { - expect(await page.$$eval(`_vue=book-item[name="The Great Gatsby"]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=book-item[name="the great gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=color-button[nested.index = 0]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=color-button[nested.nonexisting.index = 0]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=color-button[nested.index.nonexisting = 0]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=color-button[nested.index.nonexisting = 1]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=color-button[nested.value = 4.1]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=color-button[enabled = false]`, els => els.length)).toBe(4); - expect(await page.$$eval(`_vue=color-button[enabled = true] `, els => els.length)).toBe(5); - expect(await page.$$eval(`_vue=color-button[enabled = true][color = "red"]`, els => els.length)).toBe(2); - expect(await page.$$eval(`_vue=color-button[enabled = true][color = "red"i][nested.index = 6]`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=book-item[name="The Great Gatsby"]`)).toHaveCount(1); + await expect(page.locator(`_vue=book-item[name="the great gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_vue=color-button[nested.index = 0]`)).toHaveCount(1); + await expect(page.locator(`_vue=color-button[nested.nonexisting.index = 0]`)).toHaveCount(0); + await expect(page.locator(`_vue=color-button[nested.index.nonexisting = 0]`)).toHaveCount(0); + await expect(page.locator(`_vue=color-button[nested.index.nonexisting = 1]`)).toHaveCount(0); + await expect(page.locator(`_vue=color-button[nested.value = 4.1]`)).toHaveCount(1); + await expect(page.locator(`_vue=color-button[enabled = false]`)).toHaveCount(4); + await expect(page.locator(`_vue=color-button[enabled = true] `)).toHaveCount(5); + await expect(page.locator(`_vue=color-button[enabled = true][color = "red"]`)).toHaveCount(2); + await expect(page.locator(`_vue=color-button[enabled = true][color = "red"i][nested.index = 6]`)).toHaveCount(1); }); it('should exact match by props', async ({ page }) => { - expect(await page.$eval(`_vue=book-item[name = "The Great Gatsby"]`, el => el.textContent)).toBe('The Great Gatsby'); - expect(await page.$$eval(`_vue=book-item[name = "The Great Gatsby"]`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=book-item[name = "The Great Gatsby"]`)).toHaveText('The Great Gatsby'); + await expect(page.locator(`_vue=book-item[name = "The Great Gatsby"]`)).toHaveCount(1); // case sensetive by default - expect(await page.$$eval(`_vue=book-item[name = "the great gatsby"]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=book-item[name = "the great gatsby" s]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=book-item[name = "the great gatsby" S]`, els => els.length)).toBe(0); + await expect(page.locator(`_vue=book-item[name = "the great gatsby"]`)).toHaveCount(0); + await expect(page.locator(`_vue=book-item[name = "the great gatsby" s]`)).toHaveCount(0); + await expect(page.locator(`_vue=book-item[name = "the great gatsby" S]`)).toHaveCount(0); // case insensetive with flag - expect(await page.$$eval(`_vue=book-item[name = "the great gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=book-item[name = "the great gatsby" I]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=book-item[name = " The Great Gatsby "]`, els => els.length)).toBe(0); + await expect(page.locator(`_vue=book-item[name = "the great gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_vue=book-item[name = "the great gatsby" I]`)).toHaveCount(1); + await expect(page.locator(`_vue=book-item[name = " The Great Gatsby "]`)).toHaveCount(0); }); it('should partially match by props', async ({ page }) => { // Check partial matching - expect(await page.$eval(`_vue=book-item[name *= "Gatsby"]`, el => el.textContent)).toBe('The Great Gatsby'); - expect(await page.$$eval(`_vue=book-item[name *= "Gatsby"]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=[name *= "Gatsby"]`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=book-item[name *= "Gatsby"]`)).toHaveText('The Great Gatsby'); + await expect(page.locator(`_vue=book-item[name *= "Gatsby"]`)).toHaveCount(1); + await expect(page.locator(`_vue=[name *= "Gatsby"]`)).toHaveCount(1); - expect(await page.$$eval(`_vue=book-item[name = "Gatsby"]`, els => els.length)).toBe(0); + await expect(page.locator(`_vue=book-item[name = "Gatsby"]`)).toHaveCount(0); }); it('should support all string operators', async ({ page }) => { - expect(await page.$$eval(`_vue=color-button[color = "red"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color |= "red"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color $= "ed"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color ^= "gr"]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color ~= "e"]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=book-item[name ~= "gatsby" i]`, els => els.length)).toBe(1); - expect(await page.$$eval(`_vue=book-item[name *= " gatsby" i]`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=color-button[color = "red"]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color |= "red"]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color $= "ed"]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color ^= "gr"]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color ~= "e"]`)).toHaveCount(0); + await expect(page.locator(`_vue=book-item[name ~= "gatsby" i]`)).toHaveCount(1); + await expect(page.locator(`_vue=book-item[name *= " gatsby" i]`)).toHaveCount(1); }); it('should support regex', async ({ page }) => { - expect(await page.$$eval(`_vue=color-button[color = /red/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color = /^red$/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color = /RED/i]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color = /[pqr]ed/]`, els => els.length)).toBe(3); - expect(await page.$$eval(`_vue=color-button[color = /[pq]ed/]`, els => els.length)).toBe(0); - expect(await page.$$eval(`_vue=book-item[name = /gat.by/i]`, els => els.length)).toBe(1); + await expect(page.locator(`_vue=color-button[color = /red/]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color = /^red$/]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color = /RED/i]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color = /[pqr]ed/]`)).toHaveCount(3); + await expect(page.locator(`_vue=color-button[color = /[pq]ed/]`)).toHaveCount(0); + await expect(page.locator(`_vue=book-item[name = /gat.by/i]`)).toHaveCount(1); }); it('should support truthy querying', async ({ page }) => { - expect(await page.$$eval(`_vue=color-button[enabled]`, els => els.length)).toBe(5); + await expect(page.locator(`_vue=color-button[enabled]`)).toHaveCount(5); }); it('should support nested vue trees', async ({ page }) => {