Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(ct): vue throw when updating a native html element (#22392)

Browse source 
Related to: https://github.com/microsoft/playwright/issues/22328.
This commit is contained in:
Sander 2023-04-19 16:28:00 +02:00 committed by GitHub
parent 49c9284bc7
commit b3b624b0c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-ct-vue/registerSource.mjs
View file

@ -253,6 +253,9 @@ window.playwrightUpdate = async (rootElement, options) => {
if (!wrapper) if (!wrapper)
throw new Error('Component was not mounted'); throw new Error('Component was not mounted');
if (!wrapper.component)
throw new Error('Updating a native HTML element is not supported');
const { slots, listeners, props } = __pwCreateComponent(options); const { slots, listeners, props } = __pwCreateComponent(options);
wrapper.component.slots = __pwWrapFunctions(slots); wrapper.component.slots = __pwWrapFunctions(slots);

8
tests/components/ct-vue-cli/tests/update/update.spec.tsx
View file

@ -13,3 +13,11 @@ test('renderer and keep the component instance intact', async ({ mount }) => {
await expect(component.getByTestId('remount-count')).toContainText('1'); await expect(component.getByTestId('remount-count')).toContainText('1');
}); });
test('throw error when updating a native html element', async ({ mount }) => {
const component = await mount(<div id="1337"></div>);
await expect(async () => {
await component.update(<div id="9001"></div>);
}).rejects.toThrowError('Updating a native HTML element is not supported');
});

8
tests/components/ct-vue-vite/tests/update/update.spec.tsx
View file

@ -43,3 +43,11 @@ test('update slots without remounting', async ({ mount }) => {
await expect(component.getByTestId('remount-count')).toContainText('1'); await expect(component.getByTestId('remount-count')).toContainText('1');
}); });
test('throw error when updating a native html element', async ({ mount }) => {
const component = await mount(<div id="1337"></div>);
await expect(async () => {
await component.update(<div id="9001"></div>);
}).rejects.toThrowError('Updating a native HTML element is not supported');
});