Apply suggestions from code review

Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-09-30 13:26:15 +02:00 committed by GitHub
parent db74ba16e1
commit b3ded115fa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -214,14 +214,14 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
os: [ubuntu-20.04, macos-13, windows-latest] os: [ubuntu-20.04, macos-13, windows-latest]
headless: [true, false] headed: ['--headed', '']
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: ./.github/actions/run-test - uses: ./.github/actions/run-test
with: with:
browsers-to-install: chromium-tip-of-tree browsers-to-install: chromium-tip-of-tree
command: npm run ctest ${{ matrix.headless && '--headless' || '' }} command: npm run ctest -- ${{ matrix.headed }}
bot-name: "tip-of-tree-${{ matrix.os }}" bot-name: "tip-of-tree-${{ matrix.os }}${{ matrix.headed }}"
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}