From b419527aabeb8defbc548e5214e689973e6a2995 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 29 Jan 2025 04:50:32 -0500 Subject: [PATCH] fix(firefox): disable fetch keep-alive for now before a proper fix (#34530) --- packages/playwright-core/src/server/firefox/ffBrowser.ts | 4 +++- tests/page/page-event-request.spec.ts | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/firefox/ffBrowser.ts b/packages/playwright-core/src/server/firefox/ffBrowser.ts index 1d1c60e6ce..df314ed4de 100644 --- a/packages/playwright-core/src/server/firefox/ffBrowser.ts +++ b/packages/playwright-core/src/server/firefox/ffBrowser.ts @@ -435,4 +435,6 @@ function toJugglerProxyOptions(proxy: types.ProxySettings) { // Prefs for quick fixes that didn't make it to the build. // Should all be moved to `playwright.cfg`. -const kBandaidFirefoxUserPrefs = {}; +const kBandaidFirefoxUserPrefs = { + 'dom.fetchKeepalive.enabled': false, +}; diff --git a/tests/page/page-event-request.spec.ts b/tests/page/page-event-request.spec.ts index b2e13a4c2f..84717026a8 100644 --- a/tests/page/page-event-request.spec.ts +++ b/tests/page/page-event-request.spec.ts @@ -47,7 +47,6 @@ it('should fire for fetches with keepalive: true', { description: 'https://github.com/microsoft/playwright/issues/34497' } }, async ({ page, server, browserName }) => { - it.fixme(browserName === 'firefox'); const requests = []; page.on('request', request => requests.push(request)); await page.goto(server.EMPTY_PAGE);