From b4ac7aaa4406fa9711affbf225f5217f5adb99d5 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Mon, 4 Nov 2024 14:43:30 +0100 Subject: [PATCH] use callback --- packages/trace-viewer/src/ui/workbench.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/trace-viewer/src/ui/workbench.tsx b/packages/trace-viewer/src/ui/workbench.tsx index 847cc094d4..aea939fdc7 100644 --- a/packages/trace-viewer/src/ui/workbench.tsx +++ b/packages/trace-viewer/src/ui/workbench.tsx @@ -146,6 +146,11 @@ export const Workbench: React.FunctionComponent<{ selectPropertiesTab('inspector'); }, [selectPropertiesTab]); + const revealAttachment = React.useCallback((attachment: AfterActionTraceEventAttachment) => { + selectPropertiesTab('attachments'); + setRevealedAttachment(attachment); + }, [selectPropertiesTab]); + React.useEffect(() => { if (revealSource) selectPropertiesTab('source'); @@ -298,10 +303,7 @@ export const Workbench: React.FunctionComponent<{ setSelectedTime={setSelectedTime} onSelected={onActionSelected} onHighlighted={setHighlightedAction} - revealAttachment={attachment => { - selectPropertiesTab('attachments'); - setRevealedAttachment(attachment); - }} + revealAttachment={revealAttachment} revealConsole={() => selectPropertiesTab('console')} isLive={isLive} />