Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1 from Voicemod-Sociedad-Limitada/feat/ignore-download-chromium

Browse source 
feat: setDownloadBehavior chromium request skippable by env variable
This commit is contained in:
vm-luisfmm 2024-06-10 17:16:32 +02:00 committed by GitHub
parent f17d0440a7 e36d7c5c60
commit b892909912
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
packages/playwright-core/src/server/chromium/crBrowser.ts
View file

@ -348,13 +348,15 @@ export class CRBrowserContext extends BrowserContext {
override async _initialize() { override async _initialize() {
assert(!Array.from(this._browser._crPages.values()).some(page => page._browserContext === this)); assert(!Array.from(this._browser._crPages.values()).some(page => page._browserContext === this));
const promises: Promise<any>[] = [super._initialize()]; const promises: Promise<any>[] = [super._initialize()];
if (this._browser.options.name !== 'electron' && this._browser.options.name !== 'clank' && this._options.acceptDownloads !== 'internal-browser-default') { if (!process.env.PLAYWRIGHT_IGNORE_DOWNLOAD_BEHAVIOUR) {
promises.push(this._browser._session.send('Browser.setDownloadBehavior', { if (this._browser.options.name !== 'electron' && this._browser.options.name !== 'clank' && this._options.acceptDownloads !== 'internal-browser-default') {
behavior: this._options.acceptDownloads === 'accept' ? 'allowAndName' : 'deny', promises.push(this._browser._session.send('Browser.setDownloadBehavior', {
browserContextId: this._browserContextId, behavior: this._options.acceptDownloads === 'accept' ? 'allowAndName' : 'deny',
downloadPath: this._browser.options.downloadsPath, browserContextId: this._browserContextId,
eventsEnabled: true, downloadPath: this._browser.options.downloadsPath,
})); eventsEnabled: true,
}));
}
} }
await Promise.all(promises); await Promise.all(promises);
} }