From b95b435e016cb3aff41158314e463e46b5076120 Mon Sep 17 00:00:00 2001
From: Simon Knott <info@simonknott.de>
Date: Fri, 26 Jul 2024 14:29:27 +0200
Subject: [PATCH] remove `listChanged` event

the event isn't consumed from vscode, so we can do this without breaking it
---
 .../src/isomorphic/testServerConnection.ts       |  5 -----
 .../src/isomorphic/testServerInterface.ts        |  2 --
 packages/playwright/src/runner/testServer.ts     | 16 +++++++++-------
 packages/trace-viewer/src/ui/uiModeView.tsx      |  4 ----
 4 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/packages/playwright/src/isomorphic/testServerConnection.ts b/packages/playwright/src/isomorphic/testServerConnection.ts
index 156af26e8c..34ce0e31ef 100644
--- a/packages/playwright/src/isomorphic/testServerConnection.ts
+++ b/packages/playwright/src/isomorphic/testServerConnection.ts
@@ -23,14 +23,12 @@ export class TestServerConnection implements TestServerInterface, TestServerInte
   readonly onClose: events.Event<void>;
   readonly onReport: events.Event<any>;
   readonly onStdio: events.Event<{ type: 'stderr' | 'stdout'; text?: string | undefined; buffer?: string | undefined; }>;
-  readonly onListChanged: events.Event<void>;
   readonly onTestFilesChanged: events.Event<{ testFiles: string[] }>;
   readonly onLoadTraceRequested: events.Event<{ traceUrl: string }>;
 
   private _onCloseEmitter = new events.EventEmitter<void>();
   private _onReportEmitter = new events.EventEmitter<any>();
   private _onStdioEmitter = new events.EventEmitter<{ type: 'stderr' | 'stdout'; text?: string | undefined; buffer?: string | undefined; }>();
-  private _onListChangedEmitter = new events.EventEmitter<void>();
   private _onTestFilesChangedEmitter = new events.EventEmitter<{ testFiles: string[] }>();
   private _onLoadTraceRequestedEmitter = new events.EventEmitter<{ traceUrl: string }>();
 
@@ -44,7 +42,6 @@ export class TestServerConnection implements TestServerInterface, TestServerInte
     this.onClose = this._onCloseEmitter.event;
     this.onReport = this._onReportEmitter.event;
     this.onStdio = this._onStdioEmitter.event;
-    this.onListChanged = this._onListChangedEmitter.event;
     this.onTestFilesChanged = this._onTestFilesChangedEmitter.event;
     this.onLoadTraceRequested = this._onLoadTraceRequestedEmitter.event;
 
@@ -103,8 +100,6 @@ export class TestServerConnection implements TestServerInterface, TestServerInte
       this._onReportEmitter.fire(params);
     else if (method === 'stdio')
       this._onStdioEmitter.fire(params);
-    else if (method === 'listChanged')
-      this._onListChangedEmitter.fire(params);
     else if (method === 'testFilesChanged')
       this._onTestFilesChangedEmitter.fire(params);
     else if (method === 'loadTraceRequested')
diff --git a/packages/playwright/src/isomorphic/testServerInterface.ts b/packages/playwright/src/isomorphic/testServerInterface.ts
index 08214ee723..0460ae56d9 100644
--- a/packages/playwright/src/isomorphic/testServerInterface.ts
+++ b/packages/playwright/src/isomorphic/testServerInterface.ts
@@ -118,7 +118,6 @@ export interface TestServerInterface {
 export interface TestServerInterfaceEvents {
   onReport: Event<any>;
   onStdio: Event<{ type: 'stdout' | 'stderr', text?: string, buffer?: string }>;
-  onListChanged: Event<void>;
   onTestFilesChanged: Event<{ testFiles: string[] }>;
   onLoadTraceRequested: Event<{ traceUrl: string }>;
 }
@@ -126,7 +125,6 @@ export interface TestServerInterfaceEvents {
 export interface TestServerInterfaceEventEmitters {
   dispatchEvent(event: 'report', params: ReportEntry): void;
   dispatchEvent(event: 'stdio', params: { type: 'stdout' | 'stderr', text?: string, buffer?: string }): void;
-  dispatchEvent(event: 'listChanged', params: {}): void;
   dispatchEvent(event: 'testFilesChanged', params: { testFiles: string[] }): void;
   dispatchEvent(event: 'loadTraceRequested', params: { traceUrl: string }): void;
 }
diff --git a/packages/playwright/src/runner/testServer.ts b/packages/playwright/src/runner/testServer.ts
index 559f95514a..a6cd770af7 100644
--- a/packages/playwright/src/runner/testServer.ts
+++ b/packages/playwright/src/runner/testServer.ts
@@ -27,7 +27,7 @@ import { TestRun, createTaskRunnerForList, createTaskRunnerForTestServer, create
 import { open } from 'playwright-core/lib/utilsBundle';
 import ListReporter from '../reporters/list';
 import { SigIntWatcher } from './sigIntWatcher';
-import { Watcher } from '../fsWatcher';
+import { type FSEvent, Watcher } from '../fsWatcher';
 import type { ReportEntry, TestServerInterface, TestServerInterfaceEventEmitters } from '../isomorphic/testServerInterface';
 import { Runner } from './runner';
 import type { ConfigCLIOverrides } from '../common/ipc';
@@ -86,15 +86,17 @@ class TestServerDispatcher implements TestServerInterface {
           gracefullyProcessExitDoNotHang(0);
       },
     };
-    this._globalWatcher = new Watcher('deep', () => this._dispatchEvent('listChanged', {}));
-    this._testWatcher = new Watcher('flat', events => {
-      const collector = new Set<string>();
-      events.forEach(f => collectAffectedTestFiles(f.file, collector));
-      this._dispatchEvent('testFilesChanged', { testFiles: [...collector] });
-    });
+    this._globalWatcher = new Watcher('deep', events => this._checkForChangedTestFiles(events));
+    this._testWatcher = new Watcher('flat', events => this._checkForChangedTestFiles(events));
     this._dispatchEvent = (method, params) => this.transport.sendEvent?.(method, params);
   }
 
+  private _checkForChangedTestFiles(events: FSEvent[]) {
+    const collector = new Set<string>();
+    events.forEach(f => collectAffectedTestFiles(f.file, collector));
+    this._dispatchEvent('testFilesChanged', { testFiles: [...collector] });
+  }
+
   private async _wireReporter(messageSink: (message: any) => void) {
     return await createReporterForTestServer(this._serializer, messageSink);
   }
diff --git a/packages/trace-viewer/src/ui/uiModeView.tsx b/packages/trace-viewer/src/ui/uiModeView.tsx
index 56123eb74e..2a968c7618 100644
--- a/packages/trace-viewer/src/ui/uiModeView.tsx
+++ b/packages/trace-viewer/src/ui/uiModeView.tsx
@@ -243,10 +243,6 @@ export const UIModeView: React.FC<{}> = ({
     await commandQueue.current;
   }, [testServerConnection, teleSuiteUpdater]);
 
-  React.useEffect(() => {
-    testServerConnection?.onListChanged(updateList);
-  }, [testServerConnection, updateList]);
-
   // Update project filter default values.
   React.useEffect(() => {
     if (!testModel)