From b9dcfb9909e099c1b1eefbcbd4b76a7719eecf5a Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 30 Sep 2020 17:23:13 -0700 Subject: [PATCH] test: minor fixes (#4024) - missing await - missing `defaultBrowserOptions` that's important to respect `FFPATH` (and other custom browsers) --- test/channels.spec.ts | 4 ++-- test/downloads-path.spec.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/channels.spec.ts b/test/channels.spec.ts index fc1b1abfdf..04644f33bb 100644 --- a/test/channels.spec.ts +++ b/test/channels.spec.ts @@ -162,8 +162,8 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions}) await expectScopeState(browserType, GOLDEN_PRECONDITION); }); -it('should work with the domain module', async ({ domain, browserType }) => { - const browser = await browserType.launch(); +it('should work with the domain module', async ({ domain, browserType, defaultBrowserOptions }) => { + const browser = await browserType.launch(defaultBrowserOptions); const page = await browser.newPage(); const result = await page.evaluate(() => 1 + 1); expect(result).toBe(2); diff --git a/test/downloads-path.spec.ts b/test/downloads-path.spec.ts index 55dfd5d3ab..1439135e73 100644 --- a/test/downloads-path.spec.ts +++ b/test/downloads-path.spec.ts @@ -52,7 +52,7 @@ defineTestFixture('persistentDownloadsContext', async ({server, launchPersistent acceptDownloads: true } ); - page.setContent(`download`); + await page.setContent(`download`); await test(context); await context.close(); });