From bad91d5e842eb0dd22637f00ec9ccc354cb8d2b9 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Mon, 10 Feb 2025 16:37:20 +0100 Subject: [PATCH] nice hook --- packages/trace-viewer/src/ui/errorsTab.tsx | 12 ++++++++++-- packages/trace-viewer/src/ui/uiModeView.tsx | 7 +++---- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/trace-viewer/src/ui/errorsTab.tsx b/packages/trace-viewer/src/ui/errorsTab.tsx index cd32af9740..420c556d40 100644 --- a/packages/trace-viewer/src/ui/errorsTab.tsx +++ b/packages/trace-viewer/src/ui/errorsTab.tsx @@ -26,7 +26,15 @@ import { attachmentURL } from './attachmentsTab'; import { fixTestPrompt } from '@web/components/prompts'; import type { GitCommitInfo } from '@testIsomorphic/types'; -export const GitCommitInfoContext = React.createContext(undefined); +const GitCommitInfoContext = React.createContext(undefined); + +export function GitCommitInfoProvider({ children, gitCommitInfo }: React.PropsWithChildren<{ gitCommitInfo: GitCommitInfo }>) { + return {children}; +} + +export function useGitCommitInfo() { + return React.useContext(GitCommitInfoContext); +} const PromptButton: React.FC<{ error: string; @@ -47,7 +55,7 @@ const PromptButton: React.FC<{ } }, [actions]); - const gitCommitInfo = React.useContext(GitCommitInfoContext); + const gitCommitInfo = useGitCommitInfo(); const prompt = React.useMemo( () => fixTestPrompt( error, diff --git a/packages/trace-viewer/src/ui/uiModeView.tsx b/packages/trace-viewer/src/ui/uiModeView.tsx index 4eff5f1fa5..8e27ed0137 100644 --- a/packages/trace-viewer/src/ui/uiModeView.tsx +++ b/packages/trace-viewer/src/ui/uiModeView.tsx @@ -37,8 +37,7 @@ import { TestListView } from './uiModeTestListView'; import { TraceView } from './uiModeTraceView'; import { SettingsView } from './settingsView'; import { DefaultSettingsView } from './defaultSettingsView'; -import type { GitCommitInfo } from '@testIsomorphic/types'; -import { GitCommitInfoContext } from './errorsTab'; +import { GitCommitInfoProvider } from './errorsTab'; let xtermSize = { cols: 80, rows: 24 }; const xtermDataSource: XtermDataSource = { @@ -432,7 +431,7 @@ export const UIModeView: React.FC<{}> = ({
- + = ({ revealSource={revealSource} onOpenExternally={location => testServerConnection?.openNoReply({ location: { file: location.file, line: location.line, column: location.column } })} /> - +
} sidebar={