Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: disable firefox's webrender on Darwin (#5870)

Browse source 
References #5721
This commit is contained in:
Andrey Lushnikov 2021-03-18 00:23:23 -07:00 committed by GitHub
parent 9bd35d8271
commit bb21faf450
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/server/firefox/firefox.ts
View file

@ -42,13 +42,21 @@ export class Firefox extends BrowserType {
_amendEnvironment(env: Env, userDataDir: string, executable: string, browserArguments: string[]): Env { _amendEnvironment(env: Env, userDataDir: string, executable: string, browserArguments: string[]): Env {
if (!path.isAbsolute(os.homedir())) if (!path.isAbsolute(os.homedir()))
throw new Error(`Cannot launch Firefox with relative home directory. Did you set ${os.platform() === 'win32' ? 'USERPROFILE' : 'HOME'} to a relative path?`); throw new Error(`Cannot launch Firefox with relative home directory. Did you set ${os.platform() === 'win32' ? 'USERPROFILE' : 'HOME'} to a relative path?`);
return os.platform() === 'linux' ? { if (os.platform() === 'linux') {
...env, return {
// On linux Juggler ships the libstdc++ it was linked against. ...env,
LD_LIBRARY_PATH: `${path.dirname(executable)}:${process.env.LD_LIBRARY_PATH}`, // On linux Juggler ships the libstdc++ it was linked against.
// @see https://github.com/microsoft/playwright/issues/5721 LD_LIBRARY_PATH: `${path.dirname(executable)}:${process.env.LD_LIBRARY_PATH}`,
MOZ_WEBRENDER: 0, };
} : env; }
if (os.platform() === 'darwin') {
return {
...env,
// @see https://github.com/microsoft/playwright/issues/5721
MOZ_WEBRENDER: 0,
};
}
return env;
} }
_attemptToGracefullyCloseBrowser(transport: ConnectionTransport): void { _attemptToGracefullyCloseBrowser(transport: ConnectionTransport): void {