Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(dotnet): don't generate setters on interfaces (#6293)

Browse source
This commit is contained in:
Darío Kondratiuk 2021-04-30 01:10:59 -03:00 committed by GitHub
parent d9015b99d0
commit bb8453972a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
utils/doclint/generateDotnetApi.js
View file

@ -288,6 +288,7 @@ function renderMember(member, parent, out) {
let propertyOrigin = member.name; let propertyOrigin = member.name;
if (member.type.expression === '[string]|[float]') if (member.type.expression === '[string]|[float]')
propertyOrigin = `${member.name}String`; propertyOrigin = `${member.name}String`;
if(!member.clazz)
output(`[JsonPropertyName("${propertyOrigin}")]`) output(`[JsonPropertyName("${propertyOrigin}")]`)
if (parent && member && member.name === 'children') { // this is a special hack for Accessibility if (parent && member && member.name === 'children') { // this is a special hack for Accessibility
console.warn(`children property found in ${parent.name}, assuming array.`); console.warn(`children property found in ${parent.name}, assuming array.`);
@ -296,6 +297,9 @@ function renderMember(member, parent, out) {
if(!type.endsWith('?') && !member.required && nullableTypes.includes(type)) if(!type.endsWith('?') && !member.required && nullableTypes.includes(type))
type = `${type}?`; type = `${type}?`;
if(member.clazz)
output(`public ${type} ${name} { get; }`);
else
output(`public ${type} ${name} { get; set; }`); output(`public ${type} ${name} { get; set; }`);
} else { } else {
throw new Error(`Problem rendering a member: ${type} - ${name} (${member.kind})`); throw new Error(`Problem rendering a member: ${type} - ${name} (${member.kind})`);