Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

make _attachScreenshot use attach()

Browse source
This commit is contained in:
Simon Knott 2024-12-20 11:42:58 +01:00
parent 4c345bb01e
commit bc66311a05
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/playwright/src/index.ts
View file

@ -638,7 +638,7 @@ class ArtifactsRecorder {
try { try {
const screenshotPath = this._createScreenshotAttachmentPath(); const screenshotPath = this._createScreenshotAttachmentPath();
await fs.promises.rename(file, screenshotPath); await fs.promises.rename(file, screenshotPath);
this._attachScreenshot(screenshotPath); await this._attachScreenshot(screenshotPath);
} catch { } catch {
} }
} }
@ -665,19 +665,14 @@ class ArtifactsRecorder {
if (temporary) if (temporary)
this._temporaryScreenshots.push(screenshotPath); this._temporaryScreenshots.push(screenshotPath);
else else
this._attachScreenshot(screenshotPath); await this._attachScreenshot(screenshotPath);
} catch { } catch {
// Screenshot may fail, just ignore. // Screenshot may fail, just ignore.
} }
} }
private _attachScreenshot(screenshotPath: string) { private async _attachScreenshot(screenshotPath: string) {
const step = this._testInfo._addStep({ await this._testInfo.attach('screenshot', { path: screenshotPath, contentType: 'image/png' });
title: `attach "screenshot"`,
category: 'attach',
});
step.attachments.push({ name: 'screenshot', path: screenshotPath, contentType: 'image/png' });
step.complete({});
} }
private async _screenshotOnTestFailure() { private async _screenshotOnTestFailure() {