From bd090e67dfd3a4a87db498a79cfa01f5108212bc Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Fri, 19 May 2023 15:17:43 -0700
Subject: [PATCH] lint: prevent object string concatenation (#23172)

---
 packages/.eslintrc-with-ts-config.js                     | 9 +++++++++
 packages/.eslintrc.js                                    | 4 ++--
 packages/playwright-core/.eslintrc.js                    | 3 +++
 .../playwright-core/src/server/chromium/videoRecorder.ts | 2 +-
 packages/playwright-core/src/server/fetch.ts             | 2 +-
 packages/playwright-ct-core/.eslintrc.js                 | 3 +++
 packages/playwright-test/.eslintrc.js                    | 3 +++
 7 files changed, 22 insertions(+), 4 deletions(-)
 create mode 100644 packages/.eslintrc-with-ts-config.js
 create mode 100644 packages/playwright-core/.eslintrc.js
 create mode 100644 packages/playwright-ct-core/.eslintrc.js
 create mode 100644 packages/playwright-test/.eslintrc.js

diff --git a/packages/.eslintrc-with-ts-config.js b/packages/.eslintrc-with-ts-config.js
new file mode 100644
index 0000000000..dea9d4ef41
--- /dev/null
+++ b/packages/.eslintrc-with-ts-config.js
@@ -0,0 +1,9 @@
+module.exports = {
+  extends: ".eslintrc.js",
+  rules: {
+    "@typescript-eslint/no-base-to-string": "error",
+  },
+  parserOptions: {
+    project: "./tsconfig.json"
+  },
+};
diff --git a/packages/.eslintrc.js b/packages/.eslintrc.js
index 959d04700a..bc96726981 100644
--- a/packages/.eslintrc.js
+++ b/packages/.eslintrc.js
@@ -10,7 +10,7 @@ module.exports = {
    * Severity: 2 == error, 1 == warning, 0 == off.
    */
   "rules": {
-      "no-console": 2,
-      "no-debugger": 2
+    "no-console": 2,
+    "no-debugger": 2
   }
 };
diff --git a/packages/playwright-core/.eslintrc.js b/packages/playwright-core/.eslintrc.js
new file mode 100644
index 0000000000..ae8768db65
--- /dev/null
+++ b/packages/playwright-core/.eslintrc.js
@@ -0,0 +1,3 @@
+module.exports = {
+  extends: "../.eslintrc-with-ts-config.js",
+};
diff --git a/packages/playwright-core/src/server/chromium/videoRecorder.ts b/packages/playwright-core/src/server/chromium/videoRecorder.ts
index c41a11cd98..bfb377e79b 100644
--- a/packages/playwright-core/src/server/chromium/videoRecorder.ts
+++ b/packages/playwright-core/src/server/chromium/videoRecorder.ts
@@ -152,7 +152,7 @@ export class VideoRecorder {
   private async _sendFrame(frame: Buffer) {
     return new Promise(f => this._process!.stdin!.write(frame, f)).then(error => {
       if (error)
-        this._progress.log(`ffmpeg failed to write: ${error}`);
+        this._progress.log(`ffmpeg failed to write: ${String(error)}`);
     });
   }
 
diff --git a/packages/playwright-core/src/server/fetch.ts b/packages/playwright-core/src/server/fetch.ts
index 47ffc4ad9b..00d7aa3f34 100644
--- a/packages/playwright-core/src/server/fetch.ts
+++ b/packages/playwright-core/src/server/fetch.ts
@@ -382,7 +382,7 @@ export abstract class APIRequestContext extends SdkObject {
           const emptyStreamTransform = new SafeEmptyStreamTransform(notifyBodyFinished);
           body = pipeline(response, emptyStreamTransform, transform, e => {
             if (e)
-              reject(new Error(`failed to decompress '${encoding}' encoding: ${e}`));
+              reject(new Error(`failed to decompress '${encoding}' encoding: ${e.message}`));
           });
           body.on('error', e => reject(new Error(`failed to decompress '${encoding}' encoding: ${e}`)));
         } else {
diff --git a/packages/playwright-ct-core/.eslintrc.js b/packages/playwright-ct-core/.eslintrc.js
new file mode 100644
index 0000000000..ae8768db65
--- /dev/null
+++ b/packages/playwright-ct-core/.eslintrc.js
@@ -0,0 +1,3 @@
+module.exports = {
+  extends: "../.eslintrc-with-ts-config.js",
+};
diff --git a/packages/playwright-test/.eslintrc.js b/packages/playwright-test/.eslintrc.js
new file mode 100644
index 0000000000..ae8768db65
--- /dev/null
+++ b/packages/playwright-test/.eslintrc.js
@@ -0,0 +1,3 @@
+module.exports = {
+  extends: "../.eslintrc-with-ts-config.js",
+};