diff --git a/packages/playwright-core/src/outofprocess.ts b/packages/playwright-core/src/outofprocess.ts index 157dd8d0fa..5ef995874e 100644 --- a/packages/playwright-core/src/outofprocess.ts +++ b/packages/playwright-core/src/outofprocess.ts @@ -43,6 +43,7 @@ class PlaywrightClient { }, }); this._driverProcess.unref(); + this._driverProcess.stderr!.on('data', data => process.stderr.write(data)); const connection = new Connection(); connection.markAsRemote(); diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.ts index 6ac2cd5be0..4ce912f79d 100644 --- a/packages/playwright-core/src/server/trace/recorder/tracing.ts +++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts @@ -324,7 +324,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps for (const entry of entries) zipFile.addFile(entry.value, entry.name); zipFile.end(); - const zipFileName = state.traceFile + '.zip'; + const zipFileName = state.traceFile.file + '.zip'; zipFile.outputStream.pipe(fs.createWriteStream(zipFileName)).on('close', () => { const artifact = new Artifact(this._context, zipFileName); artifact.reportFinished(); diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.ts index 0068de5f43..6c125da67c 100644 --- a/tests/library/tracing.spec.ts +++ b/tests/library/tracing.spec.ts @@ -578,7 +578,6 @@ test('should record global request trace', async ({ request, context, server }, }); test('should store global request traces separately', async ({ request, server, playwright, browserName, mode }, testInfo) => { - test.fixme(browserName === 'chromium' && mode === 'driver', 'https://github.com/microsoft/playwright/issues/23108'); const request2 = await playwright.request.newContext(); await Promise.all([ (request as any)._tracing.start({ snapshots: true }),