From bd654db9c005f22c833579b57b32393304bb9bc3 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 18 Jul 2024 15:50:24 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dmitry Gozman Signed-off-by: Max Schmitt --- packages/trace-viewer/src/ui/timeline.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/trace-viewer/src/ui/timeline.tsx b/packages/trace-viewer/src/ui/timeline.tsx index 4fb7447d01..1471220aa2 100644 --- a/packages/trace-viewer/src/ui/timeline.tsx +++ b/packages/trace-viewer/src/ui/timeline.tsx @@ -29,7 +29,7 @@ import type { ConsoleEntry } from './consoleTab'; type TimelineBar = { action?: ActionTraceEventInContext; resource?: Entry; - consoleMessage?: ConsoleEntry + consoleMessage?: ConsoleEntry; leftPosition: number; rightPosition: number; leftTime: number; @@ -116,7 +116,7 @@ export const Timeline: React.FunctionComponent<{ for (const bar of bars) { if (highlightedAction) bar.active = bar.action === highlightedAction; - if (highlightedEntry) + else if (highlightedEntry) bar.active = bar.resource === highlightedEntry; else if (highlightedConsoleEntry) bar.active = bar.consoleMessage === highlightedConsoleEntry;