Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: add Firefox bidi tests

Browse source
This commit is contained in:
Max Schmitt 2024-09-07 09:29:16 +02:00
parent 718bd9b35f
commit bdf03cf3ad
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.github/workflows/tests_bidi.yml vendored
View file

@ -26,8 +26,7 @@ jobs:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
# TODO: add Firefox channel: [bidi-chrome-stable, bidi-firefox-stable]
channel: [bidi-chrome-stable]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
@ -36,6 +35,13 @@ jobs:
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1' PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
- name: Install Firefox
if: matrix.channel == 'bidi-firefox-stable'
run: |
# Note: Firefox via Snap doesn't work.
curl -O https://download-installer.cdn.mozilla.net/pub/firefox/releases/130.0/linux-x86_64/en-US/firefox-130.0.deb
sudo apt-get install -y libgdk-pixbuf2.0-0
sudo dpkg -i firefox-130.0.deb
- run: npm run build - run: npm run build
- run: npx playwright install --with-deps chromium - run: npx playwright install --with-deps chromium
- name: Run tests - name: Run tests

2
packages/playwright-core/src/server/bidi/bidiPage.ts
View file

@ -272,6 +272,8 @@ export class BidiPage implements PageDelegate {
} }
private async _updateViewport(): Promise<void> { private async _updateViewport(): Promise<void> {
if (this._browserContext._browser.options.name === 'firefox')
return;
const options = this._browserContext._options; const options = this._browserContext._options;
const deviceSize = this._page.emulatedSize(); const deviceSize = this._page.emulatedSize();
if (deviceSize === null) if (deviceSize === null)