Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#23171): fix(tracing): when zipping remotely, use correct file name (#23173)

Browse source 
Fixes #23108.
This commit is contained in:
Dmitry Gozman 2023-05-19 15:20:42 -07:00 committed by GitHub
parent 7effaf4f22
commit bf25a93617
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/trace/recorder/tracing.ts
View file

@ -324,7 +324,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
for (const entry of entries) for (const entry of entries)
zipFile.addFile(entry.value, entry.name); zipFile.addFile(entry.value, entry.name);
zipFile.end(); zipFile.end();
const zipFileName = state.traceFile + '.zip'; const zipFileName = state.traceFile.file + '.zip';
zipFile.outputStream.pipe(fs.createWriteStream(zipFileName)).on('close', () => { zipFile.outputStream.pipe(fs.createWriteStream(zipFileName)).on('close', () => {
const artifact = new Artifact(this._context, zipFileName); const artifact = new Artifact(this._context, zipFileName);
artifact.reportFinished(); artifact.reportFinished();

1
tests/library/tracing.spec.ts
View file

@ -578,7 +578,6 @@ test('should record global request trace', async ({ request, context, server },
}); });
test('should store global request traces separately', async ({ request, server, playwright, browserName, mode }, testInfo) => { test('should store global request traces separately', async ({ request, server, playwright, browserName, mode }, testInfo) => {
test.fixme(browserName === 'chromium' && mode === 'driver', 'https://github.com/microsoft/playwright/issues/23108');
const request2 = await playwright.request.newContext(); const request2 = await playwright.request.newContext();
await Promise.all([ await Promise.all([
(request as any)._tracing.start({ snapshots: true }), (request as any)._tracing.start({ snapshots: true }),