Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(ui): reset higlighted action on keyboard navigation

Browse source
This commit is contained in:
Simon Knott 2024-08-07 16:55:59 +02:00
parent ea747afcdd
commit bf871e8792
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/trace-viewer/src/ui/workbench.tsx
View file

@ -113,8 +113,9 @@ export const Workbench: React.FunctionComponent<{
const onActionSelected = React.useCallback((action: modelUtil.ActionTraceEventInContext) => { const onActionSelected = React.useCallback((action: modelUtil.ActionTraceEventInContext) => {
setSelectedAction(action); setSelectedAction(action);
setHighlightedAction(undefined);
onSelectionChanged?.(action); onSelectionChanged?.(action);
}, [setSelectedAction, onSelectionChanged]); }, [setSelectedAction, onSelectionChanged, setHighlightedAction]);
const selectPropertiesTab = React.useCallback((tab: string) => { const selectPropertiesTab = React.useCallback((tab: string) => {
setSelectedPropertiesTab(tab); setSelectedPropertiesTab(tab);

1
packages/web/src/components/listView.tsx
View file

@ -128,6 +128,7 @@ export function ListView<T>({
scrollIntoViewIfNeeded(element || undefined); scrollIntoViewIfNeeded(element || undefined);
onHighlighted?.(undefined); onHighlighted?.(undefined);
onSelected?.(items[newIndex], newIndex); onSelected?.(items[newIndex], newIndex);
setHighlightedItem(undefined);
}} }}
ref={itemListRef} ref={itemListRef}
> >