Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(webkit): reload page after updating user agent (#268)

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-16 18:29:40 -07:00 committed by GitHub
parent 68a03c2e84
commit bfb8df29bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/webkit/FrameManager.ts
View file

@ -329,6 +329,7 @@ export class FrameManager implements PageDelegate {
async setUserAgent(userAgent: string): Promise<void> { async setUserAgent(userAgent: string): Promise<void> {
await this._setUserAgent(this._session, userAgent); await this._setUserAgent(this._session, userAgent);
await this.reload();
} }
async setJavaScriptEnabled(enabled: boolean): Promise<void> { async setJavaScriptEnabled(enabled: boolean): Promise<void> {

2
test/page.spec.js
View file

@ -513,7 +513,7 @@ module.exports.addTests = function({testRunner, expect, headless, playwright, FF
]); ]);
expect(request.headers['user-agent']).toBe('foobar'); expect(request.headers['user-agent']).toBe('foobar');
}); });
it.skip(WEBKIT)('should emulate device user-agent', async({page, server}) => { it('should emulate device user-agent', async({page, server}) => {
await page.goto(server.PREFIX + '/mobile.html'); await page.goto(server.PREFIX + '/mobile.html');
expect(await page.evaluate(() => navigator.userAgent)).not.toContain('iPhone'); expect(await page.evaluate(() => navigator.userAgent)).not.toContain('iPhone');
await page.setUserAgent(playwright.devices['iPhone 6'].userAgent); await page.setUserAgent(playwright.devices['iPhone 6'].userAgent);