From c054d19a5db6a03d7cd4533f380fa412b7344e84 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 14 Oct 2021 02:00:25 +0200 Subject: [PATCH] feat(webkit): roll to r1562 (#9476) Co-authored-by: Max Schmitt --- packages/playwright-core/browsers.json | 2 +- tests/page/page-request-fulfill.spec.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index b0a3484a5f..a144ecc4a1 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -23,7 +23,7 @@ }, { "name": "webkit", - "revision": "1550", + "revision": "1562", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446" diff --git a/tests/page/page-request-fulfill.spec.ts b/tests/page/page-request-fulfill.spec.ts index 0ef2524509..078c038ebe 100644 --- a/tests/page/page-request-fulfill.spec.ts +++ b/tests/page/page-request-fulfill.spec.ts @@ -251,7 +251,6 @@ it('should fetch original request and fulfill', async ({ page, server, isElectro it('should fulfill with multiple set-cookie', async ({ page, server, browserName, isElectron }) => { it.fixme(isElectron, 'Electron 14+ is required'); - it.fail(browserName === 'webkit', 'Response contained invalid HTTP headers'); const cookies = ['a=b', 'c=d']; await page.route('**/empty.html', async route => { route.fulfill({ @@ -271,7 +270,6 @@ it('should fulfill with multiple set-cookie', async ({ page, server, browserName }); it('should fulfill with fetch response that has multiple set-cookie', async ({ playwright, page, server, browserName }) => { - it.fail(browserName === 'webkit', 'Response contained invalid HTTP headers'); server.setRoute('/empty.html', (req, res) => { res.setHeader('Set-Cookie', ['a=b', 'c=d']); res.setHeader('Content-Type', 'text/html'); @@ -289,6 +287,7 @@ it('should fulfill with fetch response that has multiple set-cookie', async ({ p it('headerValue should return set-cookie from intercepted response', async ({ page, server, browserName }) => { it.fail(browserName === 'chromium', 'Set-Cookie is missing in response after interception'); + it.fixme(browserName === 'webkit', 'Set-Cookie with \n in intercepted response does not pass validation in WebCore, see also https://github.com/microsoft/playwright/pull/9273'); await page.route('**/empty.html', async route => { route.fulfill({ status: 200,