Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(launchServer): return precise wsAddress

Browse source
This commit is contained in:
Max Schmitt 2024-05-27 11:29:45 +02:00
parent a7599ad509
commit c14084be84
3 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/api/class-browserserver.md
View file

@ -31,5 +31,3 @@ Browser websocket url.
Browser websocket endpoint which can be used as an argument to [`method: BrowserType.connect`] to establish connection Browser websocket endpoint which can be used as an argument to [`method: BrowserType.connect`] to establish connection
to the browser. to the browser.
Note that if the listen `host` option in `launchServer` options is not specified, localhost will be output anyway, even if the actual listening address is an unspecified address.

8
packages/playwright-core/src/utils/wsServer.ts
View file

@ -77,8 +77,12 @@ export class WSServer {
reject(new Error('Could not bind server socket')); reject(new Error('Could not bind server socket'));
return; return;
} }
const wsEndpoint = typeof address === 'string' ? `${address}${path}` : `ws://${hostname || 'localhost'}:${address.port}${path}`; if (typeof address === 'string') {
resolve(wsEndpoint); resolve(`${address}${path}`);
return;
}
const resolvedHost = address.family === 'IPv4' ? address.address : `[${address.address}]`;
resolve(`ws://${resolvedHost}:${address.port}${path}`);
}).on('error', reject); }).on('error', reject);
}); });

3
packages/playwright-core/types/types.d.ts vendored
View file

@ -17215,9 +17215,6 @@ export interface BrowserServer {
* Browser websocket endpoint which can be used as an argument to * Browser websocket endpoint which can be used as an argument to
* [browserType.connect(wsEndpoint[, options])](https://playwright.dev/docs/api/class-browsertype#browser-type-connect) * [browserType.connect(wsEndpoint[, options])](https://playwright.dev/docs/api/class-browsertype#browser-type-connect)
* to establish connection to the browser. * to establish connection to the browser.
*
* Note that if the listen `host` option in `launchServer` options is not specified, localhost will be output anyway,
* even if the actual listening address is an unspecified address.
*/ */
wsEndpoint(): string; wsEndpoint(): string;