Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

docs: improve locators in fixtures (#19210)

Browse source
This commit is contained in:
Debbie O'Brien 2022-12-15 10:21:08 +01:00 committed by GitHub
parent 1dcb8f643d
commit c1a1090eb3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
docs/src/test-fixtures-js.md
View file

@ -14,8 +14,8 @@ const { test, expect } = require('@playwright/test');
test('basic test', async ({ page }) => { test('basic test', async ({ page }) => {
await page.goto('https://playwright.dev/'); await page.goto('https://playwright.dev/');
const title = page.locator('.navbar__inner .navbar__title');
await expect(title).toHaveText('Playwright'); await expect(page).toHaveTitle(/Playwright/);
}); });
``` ```
@ -24,8 +24,8 @@ import { test, expect } from '@playwright/test';
test('basic test', async ({ page }) => { test('basic test', async ({ page }) => {
await page.goto('https://playwright.dev/'); await page.goto('https://playwright.dev/');
const title = page.locator('.navbar__inner .navbar__title');
await expect(title).toHaveText('Playwright'); await expect(page).toHaveTitle(/Playwright/);
}); });
``` ```
@ -234,7 +234,7 @@ test.beforeEach(async ({ settingsPage }) => {
test('basic test', async ({ todoPage, page }) => { test('basic test', async ({ todoPage, page }) => {
await todoPage.addToDo('something nice'); await todoPage.addToDo('something nice');
await expect(page.locator('.todo-item')).toContainText(['something nice']); await expect(page.getByTestId('todo-title')).toContainText(['something nice']);
}); });
``` ```
@ -247,7 +247,7 @@ test.beforeEach(async ({ settingsPage }) => {
test('basic test', async ({ todoPage, page }) => { test('basic test', async ({ todoPage, page }) => {
await todoPage.addToDo('something nice'); await todoPage.addToDo('something nice');
await expect(page.locator('.todo-item')).toContainText(['something nice']); await expect(page.getByTestId('todo-title')).toContainText(['something nice']);
}); });
``` ```
@ -353,7 +353,7 @@ exports.test = base.test.extend({
await page.getByLabel('User Name').fill(username); await page.getByLabel('User Name').fill(username);
await page.getByLabel('Password').fill(password); await page.getByLabel('Password').fill(password);
await page.getByText('Sign in').click(); await page.getByText('Sign in').click();
await expect(page.locator('#userinfo')).toHaveText(username); await expect(page.getByTestId('userinfo')).toHaveText(username);
// Use signed-in page in the test. // Use signed-in page in the test.
await use(page); await use(page);
@ -385,7 +385,7 @@ export const test = base.extend<{}, { account: Account }>({
await page.getByLabel('Password').fill(password); await page.getByLabel('Password').fill(password);
await page.getByText('Sign up').click(); await page.getByText('Sign up').click();
// Make sure everything is ok. // Make sure everything is ok.
await expect(page.locator('#result')).toHaveText('Success'); await expect(page.getByTestId('result')).toHaveText('Success');
// Do not forget to cleanup. // Do not forget to cleanup.
await page.close(); await page.close();
@ -400,7 +400,7 @@ export const test = base.extend<{}, { account: Account }>({
await page.getByLabel('User Name').fill(username); await page.getByLabel('User Name').fill(username);
await page.getByLabel('Password').fill(password); await page.getByLabel('Password').fill(password);
await page.getByText('Sign in').click(); await page.getByText('Sign in').click();
await expect(page.locator('#userinfo')).toHaveText(username); await expect(page.getByTestId('userinfo')).toHaveText(username);
// Use signed-in page in the test. // Use signed-in page in the test.
await use(page); await use(page);