Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(release-1.14): restore action error icon (#8165)

Browse source 
PR #8163 SHA f3b35b2bbd

Fixes #8051

Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
This commit is contained in:
Andrey Lushnikov 2021-08-12 18:46:46 +03:00 committed by GitHub
parent 8977835f4e
commit c1d3ff2935
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/web/traceViewer/ui/actionList.css
View file

@ -106,7 +106,11 @@
color: var(--blue);
}
.action-entry .codicon-error {
.action-entry .codicon {
padding: 0 2px;
}
.action-entry .codicon-error, .action-entry .codicon-issues {
color: red;
}

2
src/web/traceViewer/ui/actionList.tsx
View file

@ -75,6 +75,7 @@ export const ActionList: React.FC<ActionListProps> = ({
const { metadata } = action;
const selectedSuffix = action === selectedAction ? ' selected' : '';
const highlightedSuffix = action === highlightedAction ? ' highlighted' : '';
const error = metadata.error?.error?.message;
const { errors, warnings } = modelUtil.stats(action);
return <div
className={'action-entry' + selectedSuffix + highlightedSuffix}
@ -92,6 +93,7 @@ export const ActionList: React.FC<ActionListProps> = ({
{!!errors && <div className='action-icon'><span className={'codicon codicon-error'}></span><span className="action-icon-value">{errors}</span></div>}
{!!warnings && <div className='action-icon'><span className={'codicon codicon-warning'}></span><span className="action-icon-value">{warnings}</span></div>}
</div>
{error && <div className='codicon codicon-issues' title={error} />}
</div>;
})}
</div>