Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(inspector): await inspector init to avoid races (#5829)

Browse source
This commit is contained in:
Pavel Feldman 2021-03-16 10:02:38 +08:00 committed by GitHub
parent 8565e72e63
commit c2db8da4df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/server/supplements/inspectorController.ts
View file

@ -25,7 +25,7 @@ export class InspectorController implements InstrumentationListener {
async onContextCreated(context: BrowserContext): Promise<void> { async onContextCreated(context: BrowserContext): Promise<void> {
if (isDebugMode()) if (isDebugMode())
RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true }); await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
} }
async onBeforeCall(sdkObject: SdkObject, metadata: CallMetadata): Promise<void> { async onBeforeCall(sdkObject: SdkObject, metadata: CallMetadata): Promise<void> {
@ -53,7 +53,7 @@ export class InspectorController implements InstrumentationListener {
} }
if (shouldOpenInspector(sdkObject, metadata)) if (shouldOpenInspector(sdkObject, metadata))
RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true }); await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
const recorder = await RecorderSupplement.getNoCreate(context); const recorder = await RecorderSupplement.getNoCreate(context);
await recorder?.onBeforeCall(sdkObject, metadata); await recorder?.onBeforeCall(sdkObject, metadata);