Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(tracing): do not store scripts in trace (#7970)

Browse source 
We do not need them for snapshots.
This commit is contained in:
Dmitry Gozman 2021-08-03 13:05:58 -07:00 committed by GitHub
parent 4fabe5e6e4
commit c406b23387
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/server/snapshot/snapshotter.ts
View file

@ -160,6 +160,9 @@ export class Snapshotter {
const isRedirect = response.status() >= 300 && response.status() <= 399;
if (isRedirect)
return;
// We do not need scripts for snapshots.
if (response.request().resourceType() === 'script')
return;
// Shortcut all redirects - we cannot intercept them properly.
let original = response.request();

7
tests/tracing.spec.ts
View file

@ -18,9 +18,9 @@ import { expect, contextTest as test, browserTest } from './config/browserTest';
import yauzl from 'yauzl';
import jpeg from 'jpeg-js';
test('should collect trace', async ({ context, page, server }, testInfo) => {
test('should collect trace with resources, but no js', async ({ context, page, server }, testInfo) => {
await context.tracing.start({ screenshots: true, snapshots: true });
await page.goto(server.EMPTY_PAGE);
await page.goto(server.PREFIX + '/frames/frame.html');
await page.setContent('<button>Click</button>');
await page.click('"Click"');
await page.waitForTimeout(2000); // Give it some time to produce screenshots.
@ -35,7 +35,8 @@ test('should collect trace', async ({ context, page, server }, testInfo) => {
expect(events.find(e => e.metadata?.apiName === 'page.close')).toBeTruthy();
expect(events.some(e => e.type === 'frame-snapshot')).toBeTruthy();
expect(events.some(e => e.type === 'resource-snapshot')).toBeTruthy();
expect(events.some(e => e.type === 'resource-snapshot' && e.snapshot.url.endsWith('style.css'))).toBeTruthy();
expect(events.some(e => e.type === 'resource-snapshot' && e.snapshot.url.endsWith('script.js'))).toBeFalsy();
expect(events.some(e => e.type === 'screencast-frame')).toBeTruthy();
});