From c425fcd4744d689593e5babb760a68910c2570e8 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Fri, 21 Feb 2025 13:33:20 +0000
Subject: [PATCH] fixes 1

---
 tests/assets/drag-n-drop-manual.html | 17 +----------------
 tests/page/page-drag.spec.ts         |  2 +-
 2 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/tests/assets/drag-n-drop-manual.html b/tests/assets/drag-n-drop-manual.html
index d876a8ed21..424639bf94 100644
--- a/tests/assets/drag-n-drop-manual.html
+++ b/tests/assets/drag-n-drop-manual.html
@@ -39,42 +39,33 @@ div:not(.mouse-helper) {
       <div id="target">Drop Zone</div>
     
       <script>
-        // Elements
         const sourceElement = document.getElementById('source');
         const targetElement = document.getElementById('target');
         
-        // State variables
         let isDragging = false;
         let offsetX, offsetY;
         let originalPosition = { left: 0, top: 0 };
         
-        // Mouse down handler - start dragging
         sourceElement.addEventListener('mousedown', function(e) {
           e.preventDefault();
           
-          // Store the original position
           const rect = sourceElement.getBoundingClientRect();
           originalPosition = {
             left: rect.left,
             top: rect.top
           };
           
-          // Calculate the mouse offset
           offsetX = e.clientX - rect.left;
           offsetY = e.clientY - rect.top;
           
-          // Start dragging
           isDragging = true;
           sourceElement.style.border = 'dashed'
-          
-          console.log('mousedown', e.clientX, e.clientY);
         });
         
         // Mouse move handler - move the element
         document.addEventListener('mousemove', function(e) {
           if (!isDragging) return;
           
-          // Set new position
           sourceElement.style.left = (e.clientX - offsetX) + 'px';
           sourceElement.style.top = (e.clientY - offsetY) + 'px';
         });
@@ -85,7 +76,6 @@ div:not(.mouse-helper) {
           
           isDragging = false;
           
-          // Check if dropped on target area
           const sourceRect = sourceElement.getBoundingClientRect();
           const targetRect = targetElement.getBoundingClientRect();
           
@@ -97,17 +87,14 @@ div:not(.mouse-helper) {
           );
           
           if (isOverlapping) {
-            // Successful drop - append to target
             targetElement.appendChild(sourceElement);
             
-            // Reset position relative to the new parent
             sourceElement.style.removeProperty('position')
             sourceElement.style.removeProperty('top')
             sourceElement.style.removeProperty('left')
             
             console.log('Drop successful');
           } else {
-            // Failed drop - return to original position
             sourceElement.style.left = originalPosition.left + 'px';
             sourceElement.style.top = originalPosition.top + 'px';
             
@@ -115,15 +102,13 @@ div:not(.mouse-helper) {
           }
         });
         
-        // Cancel dragging if mouse leaves the window
         document.addEventListener('mouseleave', function() {
           if (isDragging) {
             isDragging = false;
             
-            // Return to original position
             sourceElement.style.left = originalPosition.left + 'px';
             sourceElement.style.top = originalPosition.top + 'px';
           }
         });
       </script>
-    </body>
\ No newline at end of file
+    </body>
diff --git a/tests/page/page-drag.spec.ts b/tests/page/page-drag.spec.ts
index 1f618d5a76..7b25b4e604 100644
--- a/tests/page/page-drag.spec.ts
+++ b/tests/page/page-drag.spec.ts
@@ -321,7 +321,7 @@ it.describe('Drag and drop', () => {
     await page.goto(server.PREFIX + '/drag-n-drop-manual.html');
     const events = await page.evaluateHandle(() => {
       const events = [];
-      document.addEventListener('drop', (event: MouseEvent) => {
+      document.addEventListener('mousemove', (event: MouseEvent) => {
         events.push({
           type: event.type,
           x: event.clientX,