From c454788592164f123f86f5dc907a7772eff3a8e1 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 29 Nov 2024 16:09:23 +0100 Subject: [PATCH] scope _enabled check to racy action --- .../src/server/recorder/recorderCollection.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/playwright-core/src/server/recorder/recorderCollection.ts b/packages/playwright-core/src/server/recorder/recorderCollection.ts index b5216d7382..1c34511e01 100644 --- a/packages/playwright-core/src/server/recorder/recorderCollection.ts +++ b/packages/playwright-core/src/server/recorder/recorderCollection.ts @@ -79,7 +79,8 @@ export class RecorderCollection extends EventEmitter { callMetadata.error = error ? serializeError(error) : undefined; // Do not wait for onAfterCall so that performAction returned immediately after the action. mainFrame.instrumentation.onAfterCall(mainFrame, callMetadata).then(() => { - this._fireChange(); + if (this._enabled) + this._fireChange(); }).catch(() => {}); } @@ -126,8 +127,6 @@ export class RecorderCollection extends EventEmitter { } private _fireChange() { - if (!this._enabled) - return; this.emit('change', collapseActions(this._actions)); } }