From c57f1fc3908f47fe477fd4821fd82ba7e70c4799 Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Fri, 19 Feb 2021 14:23:09 -0800
Subject: [PATCH] devops(chromium): missing depot tools in prepare_checkout.sh
 script (#5525)

Make sure `prepare_checkout.sh` has depot_tools in its PATH.

Drive-by: enable goma compiler proxy auto-restart.
---
 browser_patches/chromium/build.sh             | 12 ++------
 .../chromium/ensure_depot_tools.sh            | 28 +++++++++++++++++++
 browser_patches/chromium/goma.sh              |  2 ++
 browser_patches/prepare_checkout.sh           |  3 ++
 4 files changed, 35 insertions(+), 10 deletions(-)
 create mode 100644 browser_patches/chromium/ensure_depot_tools.sh

diff --git a/browser_patches/chromium/build.sh b/browser_patches/chromium/build.sh
index 2d6bd030b4..cf75e874fb 100755
--- a/browser_patches/chromium/build.sh
+++ b/browser_patches/chromium/build.sh
@@ -13,7 +13,6 @@ EOF
 )
 
 SCRIPT_PATH=$(pwd -P)
-CRREV=$(head -1 ./BUILD_NUMBER)
 
 main() {
   if [[ $1 == "--help" || $1 == "-h" ]]; then
@@ -41,15 +40,7 @@ compile_chromium() {
     exit 1
   fi
 
-  # install depot_tools if they are not in system
-  # NOTE: as of Feb 8, 2021, windows requires manual and separate
-  # installation of depot_tools.
-  if ! command -v autoninja >/dev/null; then
-    if [[ ! -d "${SCRIPT_PATH}/depot_tools" ]]; then
-      git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git "${SCRIPT_PATH}/depot_tools"
-    fi
-    export PATH="${SCRIPT_PATH}/depot_tools:$PATH"
-  fi
+  source "${SCRIPT_PATH}/ensure_depot_tools.sh"
 
   if [[ $1 == "--compile-mac"* ]]; then
     # As of Jan, 2021 Chromium mac compilation requires Xcode12.2
@@ -135,6 +126,7 @@ mirror_chromium() {
     fi
   fi
 
+  CRREV=$(head -1 "${SCRIPT_PATH}/BUILD_NUMBER")
   if [[ "${PLATFORM}" == "--mirror-win32" ]]; then
     CHROMIUM_URL="https://storage.googleapis.com/chromium-browser-snapshots/Win/${CRREV}/chrome-win.zip"
   elif [[ "${PLATFORM}" == "--mirror-win64" ]]; then
diff --git a/browser_patches/chromium/ensure_depot_tools.sh b/browser_patches/chromium/ensure_depot_tools.sh
new file mode 100644
index 0000000000..c1d0e4bd5d
--- /dev/null
+++ b/browser_patches/chromium/ensure_depot_tools.sh
@@ -0,0 +1,28 @@
+# Since this script modifies PATH, it cannot be run in a subshell
+# and must be sourced.
+# Make sure it is sourced.
+sourced=0
+(return 0 2>/dev/null) && sourced=1 || sourced=0
+
+if [[ $sourced == 0 ]]; then
+  echo 'ERROR: cannot run this script in a subshell'
+  echo 'This file modifies $PATH of the current shell, so it must be sourced instead'
+  echo 'Use `source ensure_depot_tool.sh` instead'
+  exit 1
+fi
+
+# Install depot_tools if they are not in system, and modify $PATH
+# to include depot_tools
+if ! command -v autoninja >/dev/null; then
+  if [[ $(uname) == "MINGW"* ]]; then
+    # NOTE: as of Feb 8, 2021, windows requires manual and separate
+    # installation of depot_tools.
+    echo "ERROR: cannot automatically install depot_tools on windows. Please, install manually"
+    exit 1
+  fi
+  SCRIPT_PATH=$(cd "$(dirname "$BASH_SOURCE")"; pwd -P)
+  if [[ ! -d "${SCRIPT_PATH}/depot_tools" ]]; then
+    git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git "${SCRIPT_PATH}/depot_tools"
+  fi
+  export PATH="${SCRIPT_PATH}/depot_tools:$PATH"
+fi
diff --git a/browser_patches/chromium/goma.sh b/browser_patches/chromium/goma.sh
index fde3fc49ed..897b5bc581 100755
--- a/browser_patches/chromium/goma.sh
+++ b/browser_patches/chromium/goma.sh
@@ -16,6 +16,8 @@ fi
 
 cd electron-build-tools/third_party/goma
 
+export GOMA_START_COMPILER_PROXY=true
+
 if [[ $1 == "--help" ]]; then
   echo "$(basename $0) [login|start|stop|--help]"
   exit 0
diff --git a/browser_patches/prepare_checkout.sh b/browser_patches/prepare_checkout.sh
index 1f3d2a634a..137a4cbd1f 100755
--- a/browser_patches/prepare_checkout.sh
+++ b/browser_patches/prepare_checkout.sh
@@ -29,6 +29,9 @@ fi
 
 function prepare_chromium_checkout {
   cd "${SCRIPT_PATH}"
+
+  source "${SCRIPT_PATH}/chromium/ensure_depot_tools.sh"
+
   if [[ -z "${CR_CHECKOUT_PATH}" ]]; then
     echo "ERROR: chromium compilation requires CR_CHECKOUT_PATH to be set to reuse checkout."
     echo "NOTE: we expect '\$CR_CHECKOUT_PATH/src' to exist to be a valid chromium checkout."