From c5ab0c57f84c02419851d00019e87842a895a9ee Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Wed, 18 Dec 2024 12:47:05 +0100 Subject: [PATCH] respect revisionOverrides --- packages/playwright-core/src/server/registry/index.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/registry/index.ts b/packages/playwright-core/src/server/registry/index.ts index ff9c942f20..1e0ad87595 100644 --- a/packages/playwright-core/src/server/registry/index.ts +++ b/packages/playwright-core/src/server/registry/index.ts @@ -1094,9 +1094,12 @@ export class Registry { private _downloadURLs(descriptor: BrowsersJSONDescriptor): string[] { const paths = (DOWNLOAD_PATHS as any)[descriptor.name]; - const downloadPathTemplate: string|undefined = paths[hostPlatform] || paths['']; + let downloadPathTemplate: string|undefined = paths[hostPlatform] || paths['']; if (!downloadPathTemplate) return []; + // old webkit versions don't have brotli + if (descriptor.hasRevisionOverride && descriptor.name === 'webkit' && Number(descriptor.revision) < 2114) + downloadPathTemplate = downloadPathTemplate.replace('.tar.br', '.zip'); const downloadPath = util.format(downloadPathTemplate, descriptor.revision); let downloadURLs = PLAYWRIGHT_CDN_MIRRORS.map(mirror => `${mirror}/${downloadPath}`) ;