Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-08-23 14:43:23 +02:00 committed by GitHub
parent a895bf0ceb
commit c5affe20e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/assets/modernizr/README.md
View file

@ -1,8 +1,8 @@
# Playwright Modernizer tests # Playwright Modernizr tests
## Rolling Modernizer ## Rolling Modernizr
- [modernizer.com](modernizer.com) isn't getting updated anymore, see [here](https://github.com/Modernizr/Modernizr/issues/2490) and [here](https://github.com/Modernizr/Modernizr/commit/db96bdaff995a1d4abccb0dc69c77db7b47ad614). It only contains version 3.6. - [modernizr.com](modernizr.com) isn't getting updated anymore, see [here](https://github.com/Modernizr/Modernizr/issues/2490) and [here](https://github.com/Modernizr/Modernizr/commit/db96bdaff995a1d4abccb0dc69c77db7b47ad614). It only contains version 3.6.
- This is why we build it from source ourselves, using `roll.sh` (they recommend it). - This is why we build it from source ourselves, using `roll.sh` (they recommend it).
## Updating expectations ## Updating expectations

4
tests/assets/modernizr/roll.sh
View file

@ -1,13 +1,13 @@
#!/usr/bin/env bash #!/usr/bin/env bash
MODERNIZER_VERSION="44fa7b07c367a1814e8699e3a2f15c53fbe32df7" MODERNIZR_VERSION="44fa7b07c367a1814e8699e3a2f15c53fbe32df7"
cd "$(dirname "$0")" cd "$(dirname "$0")"
rm -rf Modernizr rm -rf Modernizr
git clone https://github.com/Modernizr/Modernizr git clone https://github.com/Modernizr/Modernizr
cd Modernizr cd Modernizr
git checkout $MODERNIZER_VERSION git checkout $MODERNIZR_VERSION
npm ci npm ci
# Modernizr minifier is not working, hence we minify with ESBuild. # Modernizr minifier is not working, hence we minify with ESBuild.