From c749b7151b826250b4a416039645fc33a722234a Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Sat, 28 Dec 2019 16:38:37 -0800 Subject: [PATCH] fix(install): don't crash generating chrome protocol (#342) --- utils/protocol-types-generator/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/protocol-types-generator/index.js b/utils/protocol-types-generator/index.js index b7d69e7542..d33342b3c8 100644 --- a/utils/protocol-types-generator/index.js +++ b/utils/protocol-types-generator/index.js @@ -12,7 +12,7 @@ async function generateChromeProtocol(revision) { const playwright = await require('../../chromium'); const browserServer = await playwright.launchServer({executablePath: revision.executablePath}); const origin = browserServer.wsEndpoint().match(/ws:\/\/([0-9A-Za-z:\.]*)\//)[1]; - const page = (await browserServer.connect()).defaultContext().newPage(); + const page = await (await browserServer.connect()).defaultContext().newPage(); await page.goto(`http://${origin}/json/protocol`); const json = JSON.parse(await page.evaluate(() => document.documentElement.innerText)); await browserServer.close();