Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: do not start tracing in default recorder (#32770)

Browse source
This commit is contained in:
Pavel Feldman 2024-09-23 15:51:27 -07:00 committed by GitHub
parent 0c8b2a7c32
commit c7a5278fb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/playwright-core/src/server/recorder/contextRecorder.ts
View file

@ -54,9 +54,11 @@ export class ContextRecorder extends EventEmitter {
private _throttledOutputFile: ThrottledFile | null = null; private _throttledOutputFile: ThrottledFile | null = null;
private _orderedLanguages: LanguageGenerator[] = []; private _orderedLanguages: LanguageGenerator[] = [];
private _listeners: RegisteredListener[] = []; private _listeners: RegisteredListener[] = [];
private _codegenMode: 'actions' | 'trace-events';
constructor(codegenMode: 'actions' | 'trace-events', context: BrowserContext, params: channels.BrowserContextEnableRecorderParams, delegate: ContextRecorderDelegate) { constructor(codegenMode: 'actions' | 'trace-events', context: BrowserContext, params: channels.BrowserContextEnableRecorderParams, delegate: ContextRecorderDelegate) {
super(); super();
this._codegenMode = codegenMode;
this._context = context; this._context = context;
this._params = params; this._params = params;
this._delegate = delegate; this._delegate = delegate;
@ -145,10 +147,12 @@ export class ContextRecorder extends EventEmitter {
setEnabled(enabled: boolean) { setEnabled(enabled: boolean) {
this._collection.setEnabled(enabled); this._collection.setEnabled(enabled);
if (enabled) if (this._codegenMode === 'trace-events') {
this._context.tracing.startChunk({ name: 'trace', title: 'trace' }).catch(() => {}); if (enabled)
else this._context.tracing.startChunk({ name: 'trace', title: 'trace' }).catch(() => {});
this._context.tracing.stopChunk({ mode: 'discard' }).catch(() => {}); else
this._context.tracing.stopChunk({ mode: 'discard' }).catch(() => {});
}
} }
dispose() { dispose() {