Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove deprecated debug controller events (#29203)

Browse source
This commit is contained in:
Pavel Feldman 2024-01-29 14:58:29 -08:00 committed by GitHub
parent e9a8fc944c
commit c85308d717
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 0 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/protocol/validator.ts
View file

@ -382,13 +382,6 @@ scheme.DebugControllerSourceChangedEvent = tObject({
scheme.DebugControllerPausedEvent = tObject({ scheme.DebugControllerPausedEvent = tObject({
paused: tBoolean, paused: tBoolean,
}); });
scheme.DebugControllerBrowsersChangedEvent = tObject({
browsers: tArray(tObject({
contexts: tArray(tObject({
pages: tArray(tString),
})),
})),
});
scheme.DebugControllerInitializeParams = tObject({ scheme.DebugControllerInitializeParams = tObject({
codegenId: tString, codegenId: tString,
sdkLanguage: tEnum(['javascript', 'python', 'java', 'csharp']), sdkLanguage: tEnum(['javascript', 'python', 'java', 'csharp']),

3
packages/playwright-core/src/server/debugController.ts
View file

@ -30,7 +30,6 @@ const internalMetadata = serverSideCallMetadata();
export class DebugController extends SdkObject { export class DebugController extends SdkObject {
static Events = { static Events = {
BrowsersChanged: 'browsersChanged',
StateChanged: 'stateChanged', StateChanged: 'stateChanged',
InspectRequested: 'inspectRequested', InspectRequested: 'inspectRequested',
SourceChanged: 'sourceChanged', SourceChanged: 'sourceChanged',
@ -194,8 +193,6 @@ export class DebugController extends SdkObject {
pageCount += context.pages().length; pageCount += context.pages().length;
} }
} }
// TODO: browsers is deprecated, remove it.
this.emit(DebugController.Events.BrowsersChanged, browsers);
this.emit(DebugController.Events.StateChanged, { pageCount }); this.emit(DebugController.Events.StateChanged, { pageCount });
} }

9
packages/protocol/src/channels.ts
View file

@ -640,7 +640,6 @@ export interface DebugControllerEventTarget {
on(event: 'stateChanged', callback: (params: DebugControllerStateChangedEvent) => void): this; on(event: 'stateChanged', callback: (params: DebugControllerStateChangedEvent) => void): this;
on(event: 'sourceChanged', callback: (params: DebugControllerSourceChangedEvent) => void): this; on(event: 'sourceChanged', callback: (params: DebugControllerSourceChangedEvent) => void): this;
on(event: 'paused', callback: (params: DebugControllerPausedEvent) => void): this; on(event: 'paused', callback: (params: DebugControllerPausedEvent) => void): this;
on(event: 'browsersChanged', callback: (params: DebugControllerBrowsersChangedEvent) => void): this;
} }
export interface DebugControllerChannel extends DebugControllerEventTarget, Channel { export interface DebugControllerChannel extends DebugControllerEventTarget, Channel {
_type_DebugController: boolean; _type_DebugController: boolean;
@ -674,13 +673,6 @@ export type DebugControllerSourceChangedEvent = {
export type DebugControllerPausedEvent = { export type DebugControllerPausedEvent = {
paused: boolean, paused: boolean,
}; };
export type DebugControllerBrowsersChangedEvent = {
browsers: {
contexts: {
pages: string[],
}[],
}[],
};
export type DebugControllerInitializeParams = { export type DebugControllerInitializeParams = {
codegenId: string, codegenId: string,
sdkLanguage: 'javascript' | 'python' | 'java' | 'csharp', sdkLanguage: 'javascript' | 'python' | 'java' | 'csharp',
@ -740,7 +732,6 @@ export interface DebugControllerEvents {
'stateChanged': DebugControllerStateChangedEvent; 'stateChanged': DebugControllerStateChangedEvent;
'sourceChanged': DebugControllerSourceChangedEvent; 'sourceChanged': DebugControllerSourceChangedEvent;
'paused': DebugControllerPausedEvent; 'paused': DebugControllerPausedEvent;
'browsersChanged': DebugControllerBrowsersChangedEvent;
} }
// ----------- SocksSupport ----------- // ----------- SocksSupport -----------

17
packages/protocol/src/protocol.yml
View file

@ -785,23 +785,6 @@ DebugController:
parameters: parameters:
paused: boolean paused: boolean
# Deprecated
browsersChanged:
parameters:
browsers:
type: array
items:
type: object
properties:
contexts:
type: array
items:
type: object
properties:
pages:
type: array
items: string
SocksSupport: SocksSupport:
type: interface type: interface