diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.ts index dad9b0c8b8..1dec4f536a 100644 --- a/packages/playwright-core/src/server/trace/recorder/tracing.ts +++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts @@ -109,7 +109,6 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps this._contextCreatedEvent.browserName = context._browser.options.name; this._contextCreatedEvent.channel = context._browser.options.channel; this._contextCreatedEvent.options = context._options; - this._contextCreatedEvent.baseURL = context._options.baseURL; } } diff --git a/packages/trace-viewer/src/entries.ts b/packages/trace-viewer/src/entries.ts index 5513221648..bca5751ab2 100644 --- a/packages/trace-viewer/src/entries.ts +++ b/packages/trace-viewer/src/entries.ts @@ -24,7 +24,6 @@ export type ContextEntry = { startTime: number; endTime: number; browserName: string; - baseURL?: string; channel?: string; platform?: string; wallTime: number; diff --git a/packages/trace-viewer/src/traceModernizer.ts b/packages/trace-viewer/src/traceModernizer.ts index 3751fb531d..e7c65ac41f 100644 --- a/packages/trace-viewer/src/traceModernizer.ts +++ b/packages/trace-viewer/src/traceModernizer.ts @@ -85,7 +85,6 @@ export class TraceModernizer { this._version = event.version; contextEntry.origin = event.origin; contextEntry.browserName = event.browserName; - contextEntry.baseURL = event.baseURL; contextEntry.channel = event.channel; contextEntry.title = event.title; contextEntry.platform = event.platform; diff --git a/packages/trace-viewer/src/ui/modelUtil.ts b/packages/trace-viewer/src/ui/modelUtil.ts index 74c80cec3c..c531822fed 100644 --- a/packages/trace-viewer/src/ui/modelUtil.ts +++ b/packages/trace-viewer/src/ui/modelUtil.ts @@ -84,7 +84,7 @@ export class MultiTraceModel { const libraryContext = contexts.find(context => context.origin === 'library'); this.browserName = libraryContext?.browserName || ''; - this.baseURL = libraryContext?.baseURL; + this.baseURL = libraryContext?.options.baseURL; this.sdkLanguage = libraryContext?.sdkLanguage; this.channel = libraryContext?.channel; this.testIdAttributeName = libraryContext?.testIdAttributeName; diff --git a/packages/trace/src/trace.ts b/packages/trace/src/trace.ts index 9b995e0d1d..0e1c5327a1 100644 --- a/packages/trace/src/trace.ts +++ b/packages/trace/src/trace.ts @@ -24,6 +24,7 @@ export type Size = { width: number, height: number }; export type VERSION = 7; export type BrowserContextEventOptions = { + baseURL?: string, viewport?: Size, deviceScaleFactor?: number, isMobile?: boolean, @@ -43,7 +44,6 @@ export type ContextCreatedTraceEvent = { options: BrowserContextEventOptions, sdkLanguage?: Language, testIdAttributeName?: string, - baseURL?: string, }; export type ScreencastFrameTraceEvent = {