Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(recorder): do not ignore signals except for navigation (#30994)

Browse source 
When a signal arrives late enough, after the last action was committed
in 5 seconds, we should still account for it. This includes downloads,
popups and dialogs, but not navigations.

Exposed by a flaky test "should record open in a new tab with url".
This commit is contained in:
Dmitry Gozman 2024-05-23 17:40:39 -07:00 committed by GitHub
parent ae1e07de10
commit c906448fe2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/recorder/codeGenerator.ts
View file

@ -130,7 +130,8 @@ export class CodeGenerator extends EventEmitter {
this._currentAction.action.signals.push(signal); this._currentAction.action.signals.push(signal);
return; return;
} }
if (this._lastAction && !this._lastAction.committed) {
if (this._lastAction && (!this._lastAction.committed || signal.name !== 'navigation')) {
const signals = this._lastAction.action.signals; const signals = this._lastAction.action.signals;
if (signal.name === 'navigation' && signals.length && signals[signals.length - 1].name === 'download') if (signal.name === 'navigation' && signals.length && signals[signals.length - 1].name === 'download')
return; return;