Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(webkit): remove url from Connection (#199)

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-10 14:11:55 -07:00 committed by Dmitry Gozman
parent c61c5b056f
commit c9bc103a00
2 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/webkit/Connection.ts
View file

@ -30,7 +30,6 @@ export const ConnectionEvents = {
}; };
export class Connection extends EventEmitter { export class Connection extends EventEmitter {
private _url: string;
_lastId = 0; _lastId = 0;
private _callbacks = new Map<number, {resolve:(o: any) => void, reject: (e: Error) => void, error: Error, method: string}>(); private _callbacks = new Map<number, {resolve:(o: any) => void, reject: (e: Error) => void, error: Error, method: string}>();
private _delay: number; private _delay: number;
@ -38,9 +37,8 @@ export class Connection extends EventEmitter {
private _sessions = new Map<string, TargetSession>(); private _sessions = new Map<string, TargetSession>();
_closed = false; _closed = false;
constructor(url: string, transport: ConnectionTransport, delay: number | undefined = 0) { constructor(transport: ConnectionTransport, delay: number | undefined = 0) {
super(); super();
this._url = url;
this._delay = delay; this._delay = delay;
this._transport = transport; this._transport = transport;
@ -52,10 +50,6 @@ export class Connection extends EventEmitter {
return session._connection; return session._connection;
} }
url(): string {
return this._url;
}
send<T extends keyof Protocol.CommandParameters>( send<T extends keyof Protocol.CommandParameters>(
method: T, method: T,
params?: Protocol.CommandParameters[T] params?: Protocol.CommandParameters[T]

2
src/webkit/Launcher.ts
View file

@ -129,7 +129,7 @@ export class Launcher {
let connection: Connection | null = null; let connection: Connection | null = null;
try { try {
const transport = new PipeTransport(webkitProcess.stdio[3] as NodeJS.WritableStream, webkitProcess.stdio[4] as NodeJS.ReadableStream); const transport = new PipeTransport(webkitProcess.stdio[3] as NodeJS.WritableStream, webkitProcess.stdio[4] as NodeJS.ReadableStream);
connection = new Connection('', transport, slowMo); connection = new Connection(transport, slowMo);
const browser = new Browser(connection, defaultViewport, webkitProcess, gracefullyCloseWebkit); const browser = new Browser(connection, defaultViewport, webkitProcess, gracefullyCloseWebkit);
await browser._waitForTarget(t => t._type === 'page'); await browser._waitForTarget(t => t._type === 'page');
return browser; return browser;