From c9c2ba79b6e1e1213b6c3d28ae58bfefd0f2345f Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 21 Nov 2024 11:47:40 -0800 Subject: [PATCH] Skip 2 tests failing on gtk4 --- tests/library/emulation-focus.spec.ts | 3 ++- tests/page/page-screenshot.spec.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/library/emulation-focus.spec.ts b/tests/library/emulation-focus.spec.ts index dc8b541608..90cbdb6016 100644 --- a/tests/library/emulation-focus.spec.ts +++ b/tests/library/emulation-focus.spec.ts @@ -101,8 +101,9 @@ it('should change document.activeElement', async ({ page, server }) => { expect(active).toEqual(['INPUT', 'TEXTAREA']); }); -it('should not affect screenshots', async ({ page, server, browserName, headless, isWindows, isHeadlessShell }) => { +it('should not affect screenshots', async ({ page, server, browserName, headless, isWindows, isLinux, isHeadlessShell }) => { it.skip(browserName === 'webkit' && isWindows && !headless, 'WebKit/Windows/headed has a larger minimal viewport. See https://github.com/microsoft/playwright/issues/22616'); + it.skip(browserName === 'webkit' && isLinux && !headless, 'WebKit headed has a larger minimal viewport on gtk4.'); it.skip(browserName === 'firefox' && !headless, 'Firefox headed produces a different image'); it.fixme(browserName === 'chromium' && !isHeadlessShell, 'https://github.com/microsoft/playwright/issues/33330'); diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts index 76985e758c..4e9114ad5d 100644 --- a/tests/page/page-screenshot.spec.ts +++ b/tests/page/page-screenshot.spec.ts @@ -280,8 +280,9 @@ it.describe('page screenshot', () => { expect(screenshot).toMatchSnapshot('screenshot-clip-odd-size.png'); }); - it('should work for canvas', async ({ page, server, isElectron, isMac, isLinux, macVersion, browserName, isHeadlessShell }) => { + it('should work for canvas', async ({ page, server, isElectron, isMac, isLinux, macVersion, browserName, isHeadlessShell, headless }) => { it.fixme(isElectron && isMac, 'Fails on the bots'); + it.fixme(browserName === 'webkit' && isLinux && !headless, 'WebKit has slightly different corners on gtk4.'); await page.setViewportSize({ width: 500, height: 500 }); await page.goto(server.PREFIX + '/screenshots/canvas.html'); const screenshot = await page.screenshot();