Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake two tests (#7115)

Browse source
This commit is contained in:
Dmitry Gozman 2021-06-14 16:01:18 -07:00 committed by GitHub
parent a3a9ccad6f
commit cc186be9a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/page/page-evaluate-no-stall.spec.ts
View file

@ -50,7 +50,8 @@ test.describe('non-stalling evaluate', () => {
// Testing this as a race. // Testing this as a race.
expect([ expect([
'Frame does not yet have a main execution context', 'Frame does not yet have a main execution context',
'Frame is currently attempting a navigation' 'Frame is currently attempting a navigation',
'Navigation interrupted the evaluation',
]).toContain(error.message); ]).toContain(error.message);
}); });
}); });

3
tests/tracing.spec.ts
View file

@ -18,11 +18,12 @@ import { expect, contextTest as test, browserTest } from './config/browserTest';
import yauzl from 'yauzl'; import yauzl from 'yauzl';
import jpeg from 'jpeg-js'; import jpeg from 'jpeg-js';
test('should collect trace', async ({ context, page, server, browserName }, testInfo) => { test('should collect trace', async ({ context, page, server }, testInfo) => {
await context.tracing.start({ name: 'test', screenshots: true, snapshots: true }); await context.tracing.start({ name: 'test', screenshots: true, snapshots: true });
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.setContent('<button>Click</button>'); await page.setContent('<button>Click</button>');
await page.click('"Click"'); await page.click('"Click"');
await page.waitForTimeout(2000); // Give it some time to produce screenshots.
await page.close(); await page.close();
await context.tracing.stop({ path: testInfo.outputPath('trace.zip') }); await context.tracing.stop({ path: testInfo.outputPath('trace.zip') });