Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(remote): make playwright server work with firefox-beta (#12039)

Browse source 
It is not considered "channel", but rather a "tool".
This commit is contained in:
Dmitry Gozman 2022-02-11 14:02:02 -08:00 committed by GitHub
parent 94fc45a3db
commit ccb09acdba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/remote/playwrightServer.ts
View file

@ -166,7 +166,7 @@ class Connection {
const playwright = createPlaywright('javascript'); const playwright = createPlaywright('javascript');
const socksProxy = await this._enableSocksProxyIfNeeded(playwright); const socksProxy = await this._enableSocksProxyIfNeeded(playwright);
const browser = await playwright[executable.browserName].launch(internalCallMetadata(), { const browser = await playwright[executable.browserName].launch(internalCallMetadata(), {
channel: executable.type === 'channel' ? executable.name : undefined, channel: executable.type === 'browser' ? undefined : executable.name,
}); });
// Close the browser on disconnect. // Close the browser on disconnect.