From cd68619786eca2471c66c251f2a84a12a05d89a7 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 5 Feb 2020 16:49:09 -0800 Subject: [PATCH] chore: fix protocol-types-generator to work with new API Follow-up to a2ab645e635797eac857b077c5f4d5986ca31820 --- utils/protocol-types-generator/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/utils/protocol-types-generator/index.js b/utils/protocol-types-generator/index.js index 4ff2d38440..5ca9ce37b4 100644 --- a/utils/protocol-types-generator/index.js +++ b/utils/protocol-types-generator/index.js @@ -10,11 +10,13 @@ async function generateChromiunProtocol(revision) { if (revision.local && fs.existsSync(outputPath)) return; const playwright = await require('../../index').chromium; - const browser = await playwright.launch({ executablePath: revision.executablePath }); + const browserServer = await playwright.launchServer({ executablePath: revision.executablePath }); + const origin = browserServer.wsEndpoint().match(/ws:\/\/([0-9A-Za-z:\.]*)\//)[1]; + const browser = await playwright.connect({ wsEndpoint: browserServer.wsEndpoint() }); const page = await browser.newPage(); await page.goto(`http://${origin}/json/protocol`); const json = JSON.parse(await page.evaluate(() => document.documentElement.innerText)); - await browser.close(); + await browserServer.kill(); fs.writeFileSync(outputPath, jsonToTS(json)); console.log(`Wrote protocol.ts to ${path.relative(process.cwd(), outputPath)}`); }