From cd70d51aa809fb3a3a9c13468fdf8a7a1ed14a9e Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Mon, 13 Nov 2023 11:44:25 -0800 Subject: [PATCH] chore: remove redundant check for highlight liveness (#28108) Closes https://github.com/microsoft/playwright/issues/28002 --- packages/playwright-core/src/server/injected/highlight.ts | 4 ---- packages/playwright-core/src/server/injected/recorder.ts | 3 --- 2 files changed, 7 deletions(-) diff --git a/packages/playwright-core/src/server/injected/highlight.ts b/packages/playwright-core/src/server/injected/highlight.ts index b9b8739656..66e05491bc 100644 --- a/packages/playwright-core/src/server/injected/highlight.ts +++ b/packages/playwright-core/src/server/injected/highlight.ts @@ -96,10 +96,6 @@ export class Highlight { this._glassPaneElement.remove(); } - isInstalled(): boolean { - return this._glassPaneElement.parentElement === this._injectedScript.document.documentElement && !this._glassPaneElement.nextElementSibling; - } - showActionPoint(x: number, y: number) { this._actionPointElement.style.top = y + 'px'; this._actionPointElement.style.left = x + 'px'; diff --git a/packages/playwright-core/src/server/injected/recorder.ts b/packages/playwright-core/src/server/injected/recorder.ts index eb7b03fb6b..b3c16ee125 100644 --- a/packages/playwright-core/src/server/injected/recorder.ts +++ b/packages/playwright-core/src/server/injected/recorder.ts @@ -842,9 +842,6 @@ export class Recorder { } installListeners() { - // Ensure we are attached to the current document, and we are on top (last element); - if (this.highlight.isInstalled()) - return; removeEventListeners(this._listeners); this._listeners = [ addEventListener(this.document, 'click', event => this._onClick(event as MouseEvent), true),