Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

config validation

Browse source
This commit is contained in:
Simon Knott 2025-02-19 09:12:31 +01:00
parent 0baadb513b
commit cdd202fe98
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/playwright/src/common/configLoader.ts
View file

@ -254,6 +254,11 @@ function validateConfig(file: string, config: Config) {
else if (typeof config.workers === 'string' && !config.workers.endsWith('%')) else if (typeof config.workers === 'string' && !config.workers.endsWith('%'))
throw errorWithFile(file, `config.workers must be a number or percentage`); throw errorWithFile(file, `config.workers must be a number or percentage`);
} }
if ('tsconfig' in config && config.tsconfig !== undefined) {
if (typeof config.tsconfig !== 'string')
throw errorWithFile(file, `config.tsconfig must be a string`);
}
} }
function validateProject(file: string, project: Project, title: string) { function validateProject(file: string, project: Project, title: string) {

13
tests/playwright-test/resolver.spec.ts
View file

@ -734,6 +734,19 @@ test('should respect config.tsconfig option', async ({ runInlineTest }) => {
expect(result.output).not.toContain(`Could not`); expect(result.output).not.toContain(`Could not`);
}); });
test('should throw on invalid config.tsconfig option', async ({ runInlineTest }) => {
const result = await runInlineTest({
'playwright.config.ts': `
export default {
tsconfig: true,
};
`,
});
expect(result.exitCode).toBe(1);
expect(result.output).toContain(`config.tsconfig must be a string`);
});
test.describe('directory imports', () => { test.describe('directory imports', () => {
test('should resolve index.js without path mapping in CJS', async ({ runInlineTest, runTSC }) => { test('should resolve index.js without path mapping in CJS', async ({ runInlineTest, runTSC }) => {
const files = { const files = {