diff --git a/packages/playwright-core/src/client/page.ts b/packages/playwright-core/src/client/page.ts index 612d36ed7a..f1d90fece2 100644 --- a/packages/playwright-core/src/client/page.ts +++ b/packages/playwright-core/src/client/page.ts @@ -786,14 +786,14 @@ export class Page extends ChannelOwner implements api.Page return [...this._workers]; } - async pause(options?: { __testHookKeepTestTimeout: boolean }) { + async pause(_options?: { __testHookKeepTestTimeout: boolean }) { if (require('inspector').url()) return; const defaultNavigationTimeout = this._browserContext._timeoutSettings.defaultNavigationTimeout(); const defaultTimeout = this._browserContext._timeoutSettings.defaultTimeout(); this._browserContext.setDefaultNavigationTimeout(0); this._browserContext.setDefaultTimeout(0); - this._instrumentation?.onWillPause({ keepTestTimeout: !!options?.__testHookKeepTestTimeout }); + this._instrumentation?.onWillPause({ keepTestTimeout: !!_options?.__testHookKeepTestTimeout }); await this._closedOrCrashedScope.safeRace(this.context()._channel.pause()); this._browserContext.setDefaultNavigationTimeout(defaultNavigationTimeout); this._browserContext.setDefaultTimeout(defaultTimeout); diff --git a/utils/doclint/missingDocs.js b/utils/doclint/missingDocs.js index 7fffc156dc..d18df13de2 100644 --- a/utils/doclint/missingDocs.js +++ b/utils/doclint/missingDocs.js @@ -120,7 +120,7 @@ function listMethods(rootNames, apiFileName) { function shouldSkipMethodByName(className, methodName) { if (methodName.startsWith('_') || methodName === 'T' || methodName === 'toString') return true; - if (/** @type {any} */(EventEmitter).prototype.hasOwnProperty(methodName)) + if (EventEmitter.prototype.hasOwnProperty(methodName)) return true; return false; } @@ -141,7 +141,7 @@ function listMethods(rootNames, apiFileName) { const memberType = checker.getTypeOfSymbolAtLocation(member, member.valueDeclaration); const signature = signatureForType(memberType); if (signature) - methods.set(name, new Set(signature.parameters.map(p => p.escapedName))); + methods.set(name, new Set(signature.parameters.filter(p => !p.escapedName.startsWith('_')).map(p => p.escapedName))); else methods.set(name, new Set()); }