Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(docs): ignore case when validating order of events and methods (#5309)

Browse source
This commit is contained in:
Anže Vodovnik 2021-02-04 19:19:38 +01:00 committed by GitHub
parent 997bd0827c
commit cf96b15051
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
utils/doclint/documentation.js
View file

@ -229,7 +229,7 @@ Documentation.Class = class {
const member2 = this.membersArray[i + 1]; const member2 = this.membersArray[i + 1];
if (member1.kind !== 'event' || member2.kind !== 'event') if (member1.kind !== 'event' || member2.kind !== 'event')
continue; continue;
if (member1.name > member2.name) if (member1.name.localeCompare(member2.name, 'en', { sensitivity: 'base' }) > 0)
errors.push(`Event '${member1.name}' in class ${this.name} breaks alphabetic ordering of events`); errors.push(`Event '${member1.name}' in class ${this.name} breaks alphabetic ordering of events`);
} }
@ -241,7 +241,7 @@ Documentation.Class = class {
continue; continue;
if (member1.kind === 'method' && member1.name === 'constructor') if (member1.kind === 'method' && member1.name === 'constructor')
continue; continue;
if (member1.name.replace(/^\$+/, '$') > member2.name.replace(/^\$+/, '$')) { if (member1.name.replace(/^\$+/, '$').localeCompare(member2.name.replace(/^\$+/, '$'), 'en', { sensitivity: 'base' }) > 0) {
let memberName1 = `${this.name}.${member1.name}`; let memberName1 = `${this.name}.${member1.name}`;
if (member1.kind === 'method') if (member1.kind === 'method')
memberName1 += '()'; memberName1 += '()';