From cfc9623a790f1eacd88fd866cd2d86a1fc780729 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 22 May 2024 22:18:03 +0200 Subject: [PATCH] fix(vscode): keep config order in vscode extension project dropdown (#30954) Relates https://github.com/microsoft/playwright/issues/30936 --- packages/playwright/src/runner/loadUtils.ts | 2 -- packages/playwright/src/runner/tasks.ts | 1 - 2 files changed, 3 deletions(-) diff --git a/packages/playwright/src/runner/loadUtils.ts b/packages/playwright/src/runner/loadUtils.ts index b138b6fae4..d7d1c7c6c8 100644 --- a/packages/playwright/src/runner/loadUtils.ts +++ b/packages/playwright/src/runner/loadUtils.ts @@ -67,14 +67,12 @@ export async function collectProjectsAndTestFiles(testRun: TestRun, doNotRunTest const projectClosure = buildProjectsClosure([...filesToRunByProject.keys()]); for (const [project, type] of projectClosure) { if (type === 'dependency') { - filesToRunByProject.delete(project); const treatProjectAsEmpty = doNotRunTestsOutsideProjectFilter && !filteredProjects.includes(project); const files = treatProjectAsEmpty ? [] : allFilesForProject.get(project) || await collectFilesForProject(project, fsCache); filesToRunByProject.set(project, files); } } - testRun.projects = [...filesToRunByProject.keys()]; testRun.projectFiles = filesToRunByProject; testRun.projectSuites = new Map(); } diff --git a/packages/playwright/src/runner/tasks.ts b/packages/playwright/src/runner/tasks.ts index 46d0ae4181..5a69b94e8b 100644 --- a/packages/playwright/src/runner/tasks.ts +++ b/packages/playwright/src/runner/tasks.ts @@ -51,7 +51,6 @@ export class TestRun { readonly failureTracker: FailureTracker; rootSuite: Suite | undefined = undefined; readonly phases: Phase[] = []; - projects: FullProjectInternal[] = []; projectFiles: Map = new Map(); projectSuites: Map = new Map();