Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#19580): fix: properly handle negated timed-out toPass matcher

Browse source
This commit is contained in:
Andrey Lushnikov 2022-12-20 08:41:32 -08:00 committed by Andrey Lushnikov
parent efa3756c16
commit d10cc91cf6
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-test/src/matchers/matchers.ts
View file

@ -358,5 +358,5 @@ export async function toPass(
`- ${timeoutMessage}`, `- ${timeoutMessage}`,
].join('\n') : timeoutMessage; ].join('\n') : timeoutMessage;
return { message, pass: false }; return { message, pass: isNot ? true : false };
} }

15
tests/playwright-test/expect-to-pass.spec.ts
View file

@ -166,4 +166,17 @@ test('should work with soft', async ({ runInlineTest }) => {
expect(stripAnsi(result.output)).toContain('Received: 2'); expect(stripAnsi(result.output)).toContain('Received: 2');
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
expect(result.failed).toBe(1); expect(result.failed).toBe(1);
}); });
test('should not accept TimeoutError', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.spec.ts': `
const { test } = pwt;
test('should fail', async () => {
await test.expect(() => {}).not.toPass({ timeout: 1 });
});
`
});
expect(result.exitCode).toBe(1);
expect(result.failed).toBe(1);
});