Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(fetch): remove content-length from redirected post requests (#9728)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-10-22 16:52:49 -07:00 committed by GitHub
parent 23aa0be15b
commit d183d364a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright-core/src/server/fetch.ts
View file

@ -226,6 +226,7 @@ export abstract class FetchRequest extends SdkObject {
postData = undefined; postData = undefined;
delete headers[`content-encoding`]; delete headers[`content-encoding`];
delete headers[`content-language`]; delete headers[`content-language`];
delete headers[`content-length`];
delete headers[`content-location`]; delete headers[`content-location`];
delete headers[`content-type`]; delete headers[`content-type`];
} }

18
tests/global-fetch.spec.ts
View file

@ -210,3 +210,21 @@ it('should abort redirected requests when context is disposed', async ({ playwri
expect(result.message).toContain('Request context disposed'); expect(result.message).toContain('Request context disposed');
await connectionClosed; await connectionClosed;
}); });
it('should remove content-length from reidrected post requests', async ({ playwright, server }) => {
server.setRedirect('/redirect', '/empty.html');
const request = await playwright.request.newContext();
const [result, req1, req2] = await Promise.all([
request.post(server.PREFIX + '/redirect', {
data: {
'foo': 'bar'
}
}),
server.waitForRequest('/redirect'),
server.waitForRequest('/empty.html')
]);
expect(result.status()).toBe(200);
expect(req1.headers['content-length']).toBe('13');
expect(req2.headers['content-length']).toBe(undefined);
await request.dispose();
});