Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: respect min allowed firefox width in video tests (#14558)

Browse source 
In firefox browser window min width is 450, setting viewport to smaller value in the tests led to unexpected image in the video.

References #14405
This commit is contained in:
Yury Semikhatsky 2022-06-01 14:21:00 -07:00 committed by GitHub
parent c53676e605
commit d1a3f3306c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
tests/library/video.spec.ts
View file

@ -346,9 +346,8 @@ it.describe('screencast', () => {
it.fixme(!headless, 'Fails on headed'); it.fixme(!headless, 'Fails on headed');
it.fixme(browserName === 'webkit' && platform === 'win32'); it.fixme(browserName === 'webkit' && platform === 'win32');
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060'); it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/14405');
const size = { width: 320, height: 240 }; const size = { width: 600, height: 400 };
// Set viewport equal to screencast frame size to avoid scaling. // Set viewport equal to screencast frame size to avoid scaling.
const context = await browser.newContext({ const context = await browser.newContext({
recordVideo: { recordVideo: {
@ -376,9 +375,9 @@ it.describe('screencast', () => {
it('should work for popups', async ({ browser, server, browserName, trace }, testInfo) => { it('should work for popups', async ({ browser, server, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060'); it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/14405'); it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/14557');
const videosPath = testInfo.outputPath(''); const videosPath = testInfo.outputPath('');
const size = { width: 450, height: 240 }; const size = { width: 600, height: 400 };
const context = await browser.newContext({ const context = await browser.newContext({
recordVideo: { recordVideo: {
dir: videosPath, dir: videosPath,
@ -516,7 +515,7 @@ it.describe('screencast', () => {
it('should capture static page in persistent context @smoke', async ({ launchPersistent, browserName, trace }, testInfo) => { it('should capture static page in persistent context @smoke', async ({ launchPersistent, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060'); it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const size = { width: 320, height: 240 }; const size = { width: 600, height: 400 };
const { context, page } = await launchPersistent({ const { context, page } = await launchPersistent({
recordVideo: { recordVideo: {
dir: testInfo.outputPath(''), dir: testInfo.outputPath(''),
@ -534,8 +533,8 @@ it.describe('screencast', () => {
const duration = videoPlayer.duration; const duration = videoPlayer.duration;
expect(duration).toBeGreaterThan(0); expect(duration).toBeGreaterThan(0);
expect(videoPlayer.videoWidth).toBe(320); expect(videoPlayer.videoWidth).toBe(600);
expect(videoPlayer.videoHeight).toBe(240); expect(videoPlayer.videoHeight).toBe(400);
{ {
const pixels = videoPlayer.seekLastFrame().data; const pixels = videoPlayer.seekLastFrame().data;
@ -658,11 +657,10 @@ it.describe('screencast', () => {
expect(files.length).toBe(1); expect(files.length).toBe(1);
}); });
it('should capture full viewport', async ({ browserType, browserName, headless }, testInfo) => { it('should capture full viewport', async ({ browserType, browserName, headless, isWindows }, testInfo) => {
it.fail(browserName === 'firefox', 'The actual picture is smaller than video frame');
it.fail(browserName === 'chromium' && !headless, 'The square is not on the video'); it.fail(browserName === 'chromium' && !headless, 'The square is not on the video');
it.fail(browserName === 'firefox' && isWindows, 'https://github.com/microsoft/playwright/issues/14405');
const size = { width: 400, height: 400 }; const size = { width: 600, height: 400 };
const browser = await browserType.launch(); const browser = await browserType.launch();
const videoDir = testInfo.outputPath(''); const videoDir = testInfo.outputPath('');
@ -692,11 +690,10 @@ it.describe('screencast', () => {
expectAll(pixels, almostRed); expectAll(pixels, almostRed);
}); });
it('should capture full viewport on hidpi', async ({ browserType, browserName, headless }, testInfo) => { it('should capture full viewport on hidpi', async ({ browserType, browserName, headless, isWindows }, testInfo) => {
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/14405');
it.fail(browserName === 'firefox', 'The actual picture is smaller than video frame');
it.fail(browserName === 'chromium' && !headless, 'The square is not on the video'); it.fail(browserName === 'chromium' && !headless, 'The square is not on the video');
const size = { width: 400, height: 400 }; it.fail(browserName === 'firefox' && isWindows, 'https://github.com/microsoft/playwright/issues/14405');
const size = { width: 600, height: 400 };
const browser = await browserType.launch(); const browser = await browserType.launch();
const videoDir = testInfo.outputPath(''); const videoDir = testInfo.outputPath('');