From d31f13468aaaa968b96be6568b9fe8de349c4130 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 10 Jan 2022 05:02:07 -0800 Subject: [PATCH] feat(webkit): roll to r1592 (#11261) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrey Lushnikov --- packages/playwright-core/browsers.json | 2 +- .../src/server/webkit/protocol.d.ts | 34 ------------------- tests/page/elementhandle-bounding-box.spec.ts | 2 +- 3 files changed, 2 insertions(+), 36 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 44cdc32239..8e339c00ff 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -23,7 +23,7 @@ }, { "name": "webkit", - "revision": "1588", + "revision": "1592", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446" diff --git a/packages/playwright-core/src/server/webkit/protocol.d.ts b/packages/playwright-core/src/server/webkit/protocol.d.ts index 9c0d62ebd6..8ca718ddd2 100644 --- a/packages/playwright-core/src/server/webkit/protocol.d.ts +++ b/packages/playwright-core/src/server/webkit/protocol.d.ts @@ -7256,36 +7256,6 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the } export type deleteAllCookiesReturnValue = { } - /** - * Returns all local storage data in the given browser context. - */ - export type getLocalStorageDataParameters = { - /** - * Browser context id. - */ - browserContextId?: ContextID; - } - export type getLocalStorageDataReturnValue = { - /** - * Local storage data. - */ - origins: OriginStorage[]; - } - /** - * Populates local storage data in the given browser context. - */ - export type setLocalStorageDataParameters = { - /** - * Browser context id. - */ - browserContextId?: ContextID; - /** - * Local storage data. - */ - origins: OriginStorage[]; - } - export type setLocalStorageDataReturnValue = { - } /** * Overrides the geolocation position or error. */ @@ -9068,8 +9038,6 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the "Playwright.getAllCookies": Playwright.getAllCookiesParameters; "Playwright.setCookies": Playwright.setCookiesParameters; "Playwright.deleteAllCookies": Playwright.deleteAllCookiesParameters; - "Playwright.getLocalStorageData": Playwright.getLocalStorageDataParameters; - "Playwright.setLocalStorageData": Playwright.setLocalStorageDataParameters; "Playwright.setGeolocationOverride": Playwright.setGeolocationOverrideParameters; "Playwright.setLanguages": Playwright.setLanguagesParameters; "Playwright.setDownloadBehavior": Playwright.setDownloadBehaviorParameters; @@ -9368,8 +9336,6 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the "Playwright.getAllCookies": Playwright.getAllCookiesReturnValue; "Playwright.setCookies": Playwright.setCookiesReturnValue; "Playwright.deleteAllCookies": Playwright.deleteAllCookiesReturnValue; - "Playwright.getLocalStorageData": Playwright.getLocalStorageDataReturnValue; - "Playwright.setLocalStorageData": Playwright.setLocalStorageDataReturnValue; "Playwright.setGeolocationOverride": Playwright.setGeolocationOverrideReturnValue; "Playwright.setLanguages": Playwright.setLanguagesReturnValue; "Playwright.setDownloadBehavior": Playwright.setDownloadBehaviorReturnValue; diff --git a/tests/page/elementhandle-bounding-box.spec.ts b/tests/page/elementhandle-bounding-box.spec.ts index ceea022bc7..35426f1b3d 100644 --- a/tests/page/elementhandle-bounding-box.spec.ts +++ b/tests/page/elementhandle-bounding-box.spec.ts @@ -39,7 +39,7 @@ it('should handle nested frames', async ({ page, server }) => { }); it('should get frame box', async ({ page, browserName }) => { - it.fail(browserName === 'webkit', 'https://github.com/microsoft/playwright/issues/10977'); + it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/10977' }); await page.setViewportSize({ width: 200, height: 200 }); await page.setContent(`