Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(test runner): remove test output for failures (#11308)

Browse source
This commit is contained in:
Dmitry Gozman 2022-01-10 13:22:09 -08:00 committed by GitHub
parent 14fd837e94
commit d36ff8a96c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-test/src/reporters/base.ts
View file

@ -58,10 +58,9 @@ export class BaseReporter implements Reporter {
suite!: Suite; suite!: Suite;
totalTestCount = 0; totalTestCount = 0;
result!: FullResult; result!: FullResult;
fileDurations = new Map<string, number>(); private fileDurations = new Map<string, number>();
monotonicStartTime: number = 0; private monotonicStartTime: number = 0;
private printTestOutput = !process.env.PWTEST_SKIP_TEST_OUTPUT; private _omitFailures: boolean;
protected _omitFailures: boolean;
private readonly _ttyWidthForTest: number; private readonly _ttyWidthForTest: number;
constructor(options: { omitFailures?: boolean } = {}) { constructor(options: { omitFailures?: boolean } = {}) {
@ -196,7 +195,6 @@ export class BaseReporter implements Reporter {
failures.forEach((test, index) => { failures.forEach((test, index) => {
console.log(formatFailure(this.config, test, { console.log(formatFailure(this.config, test, {
index: index + 1, index: index + 1,
includeStdio: this.printTestOutput
}).message); }).message);
}); });
} }

23
tests/playwright-test/reporter-base.spec.ts
View file

@ -16,7 +16,6 @@
import { test, expect, stripAscii } from './playwright-test-fixtures'; import { test, expect, stripAscii } from './playwright-test-fixtures';
import * as path from 'path'; import * as path from 'path';
import colors from 'colors/safe';
test('handle long test names', async ({ runInlineTest }) => { test('handle long test names', async ({ runInlineTest }) => {
const title = 'title'.repeat(30); const title = 'title'.repeat(30);
@ -176,28 +175,6 @@ test('should not print slow tests', async ({ runInlineTest }) => {
expect(stripAscii(result.output)).not.toContain('Slow test'); expect(stripAscii(result.output)).not.toContain('Slow test');
}); });
test('should print stdio for failures', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.js': `
const { test } = pwt;
test('fails', async ({}) => {
console.log('my log 1');
console.error('my error');
console.log('my log 2');
expect(1).toBe(2);
});
`,
}, {}, { PWTEST_SKIP_TEST_OUTPUT: '' });
expect(result.exitCode).toBe(1);
expect(result.failed).toBe(1);
expect(result.output).toContain('Test output');
expect(result.output).toContain([
'my log 1\n',
colors.red('my error\n'),
'my log 2\n',
].join(''));
});
test('should print flaky failures', async ({ runInlineTest }) => { test('should print flaky failures', async ({ runInlineTest }) => {
const result = await runInlineTest({ const result = await runInlineTest({
'a.spec.ts': ` 'a.spec.ts': `